Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(131)

Issue 5169053: Fix a few more VS2010 warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by bsalomon
Modified:
14 years ago
Reviewers:
reed1, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add SkDEBUGCODE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M experimental/Debugger/DebuggerStateView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/SkSetPoly3To3_D.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/skdiff_main.cpp View 1 4 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 6
bsalomon
14 years ago (2011-10-04 20:19:14 UTC) #1
TomH
http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp File experimental/SkSetPoly3To3_D.cpp (right): http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp#newcode14 experimental/SkSetPoly3To3_D.cpp:14: int top = static_cast<int>(result >> 31); Should this be ...
14 years ago (2011-10-04 20:21:20 UTC) #2
bsalomon
http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp File experimental/SkSetPoly3To3_D.cpp (right): http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp#newcode14 experimental/SkSetPoly3To3_D.cpp:14: int top = static_cast<int>(result >> 31); On 2011/10/04 20:21:20, ...
14 years ago (2011-10-04 20:47:13 UTC) #3
bsalomon
ping On 2011/10/04 20:47:13, bsalomon wrote: > http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp > File experimental/SkSetPoly3To3_D.cpp (right): > > http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp#newcode14 ...
14 years ago (2011-10-07 14:41:32 UTC) #4
reed1
WFM -- works for me
14 years ago (2011-10-07 17:56:21 UTC) #5
TomH
14 years ago (2011-10-10 13:05:19 UTC) #6
On 2011/10/04 20:47:13, bsalomon wrote:
> http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp
> File experimental/SkSetPoly3To3_D.cpp (right):
> 
>
http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp...
> experimental/SkSetPoly3To3_D.cpp:14: int top = static_cast<int>(result >> 31);
> On 2011/10/04 20:21:20, TomH wrote:
> > Should this be protected with a debug-only macro?
> 
> Done.
> 
> http://codereview.appspot.com/5169053/diff/1/tools/skdiff_main.cpp
> File tools/skdiff_main.cpp (right):
> 
> http://codereview.appspot.com/5169053/diff/1/tools/skdiff_main.cpp#newcode510
> tools/skdiff_main.cpp:510: retval = static_cast<int>(height * scale);
> On 2011/10/04 20:21:20, TomH wrote:
> > Do we care about floor/ceil?
> 
> I'm not sure, it's your code. :)

Hmm, as long as static_cast<> is going to be *consistent* I suppose we don't
explicitly care one way or the other.
So, if it is consistent, LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b