Fix a few more VS2010 warnings

[TomH, 2011-10-04 20:21:20]

http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp
File experimental/SkSetPoly3To3_D.cpp (right):

http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp...
experimental/SkSetPoly3To3_D.cpp:14: int top = static_cast<int>(result >> 31);
Should this be protected with a debug-only macro?

http://codereview.appspot.com/5169053/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

http://codereview.appspot.com/5169053/diff/1/tools/skdiff_main.cpp#newcode510
tools/skdiff_main.cpp:510: retval = static_cast<int>(height * scale);
Do we care about floor/ceil?

[bsalomon, 2011-10-04 20:47:13]

http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp
File experimental/SkSetPoly3To3_D.cpp (right):

http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp...
experimental/SkSetPoly3To3_D.cpp:14: int top = static_cast<int>(result >> 31);
On 2011/10/04 20:21:20, TomH wrote:
> Should this be protected with a debug-only macro?

Done.

http://codereview.appspot.com/5169053/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

http://codereview.appspot.com/5169053/diff/1/tools/skdiff_main.cpp#newcode510
tools/skdiff_main.cpp:510: retval = static_cast<int>(height * scale);
On 2011/10/04 20:21:20, TomH wrote:
> Do we care about floor/ceil?

I'm not sure, it's your code. :)

[bsalomon, 2011-10-07 14:41:32]

ping

On 2011/10/04 20:47:13, bsalomon wrote:
> http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp
> File experimental/SkSetPoly3To3_D.cpp (right):
> 
>
http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp...
> experimental/SkSetPoly3To3_D.cpp:14: int top = static_cast<int>(result >> 31);
> On 2011/10/04 20:21:20, TomH wrote:
> > Should this be protected with a debug-only macro?
> 
> Done.
> 
> http://codereview.appspot.com/5169053/diff/1/tools/skdiff_main.cpp
> File tools/skdiff_main.cpp (right):
> 
> http://codereview.appspot.com/5169053/diff/1/tools/skdiff_main.cpp#newcode510
> tools/skdiff_main.cpp:510: retval = static_cast<int>(height * scale);
> On 2011/10/04 20:21:20, TomH wrote:
> > Do we care about floor/ceil?
> 
> I'm not sure, it's your code. :)

[reed1, 2011-10-07 17:56:21]

WFM -- works for me

[TomH, 2011-10-10 13:05:19]

On 2011/10/04 20:47:13, bsalomon wrote:
> http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp
> File experimental/SkSetPoly3To3_D.cpp (right):
> 
>
http://codereview.appspot.com/5169053/diff/1/experimental/SkSetPoly3To3_D.cpp...
> experimental/SkSetPoly3To3_D.cpp:14: int top = static_cast<int>(result >> 31);
> On 2011/10/04 20:21:20, TomH wrote:
> > Should this be protected with a debug-only macro?
> 
> Done.
> 
> http://codereview.appspot.com/5169053/diff/1/tools/skdiff_main.cpp
> File tools/skdiff_main.cpp (right):
> 
> http://codereview.appspot.com/5169053/diff/1/tools/skdiff_main.cpp#newcode510
> tools/skdiff_main.cpp:510: retval = static_cast<int>(height * scale);
> On 2011/10/04 20:21:20, TomH wrote:
> > Do we care about floor/ceil?
> 
> I'm not sure, it's your code. :)

Hmm, as long as static_cast<> is going to be *consistent* I suppose we don't
explicitly care one way or the other.
So, if it is consistent, LGTM.