Issue 5167042: code review 5167042: goprotobuf: Improve and test JSON output of protocol bu...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5167042: code review 5167042: goprotobuf: Improve and test JSON output of protocol bu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by dsymonds

Modified:
14 years, 1 month ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: Improve and test JSON output of protocol buffers. This doesn't completely fix issue 18 (we need the `json:"-"` support), but the vast majority of messages don't carry unrecognized bytes, nor use extensions, so this gets 99% of the way there. Fixes issue 18.

Patch Set 1 #

Patch Set 2 : diff -r add41b3cc667 https://goprotobuf.googlecode.com/hg #

Patch Set 3 : diff -r add41b3cc667 https://goprotobuf.googlecode.com/hg #

Patch Set 4 : diff -r add41b3cc667 https://goprotobuf.googlecode.com/hg #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -30 lines)			Patch
M	compiler/generator/generator.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	compiler/testdata/imp.pb.go.golden	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	compiler/testdata/test.pb.go.golden	View	1	5 chunks	+21 lines, -21 lines	0 comments	Download
M	proto/all_test.go	View	1	2 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://goprotobuf.googlecode.com/hg

14 years, 1 month ago (2011-09-30 00:18:54 UTC) #1

dsymonds

14 years, 1 month ago (2011-09-30 00:24:29 UTC) #3

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=bc76a153ffde ***

goprotobuf: Improve and test JSON output of protocol buffers.

This doesn't completely fix issue 18 (we need the `json:"-"` support),
but the vast majority of messages don't carry unrecognized bytes, nor
use extensions, so this gets 99% of the way there.

Fixes issue 18.

R=r
CC=golang-dev
http://codereview.appspot.com/5167042

Expand All Messages | Collapse All Messages