Make django_orm models use TEXT instead of VARCHAR

[jcgregorio_google, 2011-10-03 18:20:30]

LGTM.

Looking at the code I realize I don't have any tests for the django_orm code. If
you feel so inclined that would be a great contribution.

[conleyo, 2011-10-03 21:18:28]

On 2011/10/03 18:20:30, jcgregorio_google wrote:
> LGTM.
> 
> Looking at the code I realize I don't have any tests for the django_orm code.
If
> you feel so inclined that would be a great contribution.

done.

[jcgregorio_google, 2011-10-04 12:19:23]

http://codereview.appspot.com/5165047/diff/3001/tests/test_oauth2client_djang...
File tests/test_oauth2client_django_orm.py (right):

http://codereview.appspot.com/5165047/diff/3001/tests/test_oauth2client_djang...
tests/test_oauth2client_django_orm.py:53: credentials =
self.field.to_python(self.pickle)
What is this line supposed to do?

[conleyo, 2011-10-04 16:17:27]

On 2011/10/04 12:19:23, jcgregorio_google wrote:
>
http://codereview.appspot.com/5165047/diff/3001/tests/test_oauth2client_djang...
> File tests/test_oauth2client_django_orm.py (right):
> 
>
http://codereview.appspot.com/5165047/diff/3001/tests/test_oauth2client_djang...
> tests/test_oauth2client_django_orm.py:53: credentials =
> self.field.to_python(self.pickle)
> What is this line supposed to do?

[conleyo, 2011-10-04 16:17:45]

http://codereview.appspot.com/5165047/diff/3001/tests/test_oauth2client_djang...
File tests/test_oauth2client_django_orm.py (right):

http://codereview.appspot.com/5165047/diff/3001/tests/test_oauth2client_djang...
tests/test_oauth2client_django_orm.py:53: credentials =
self.field.to_python(self.pickle)
On 2011/10/04 12:19:23, jcgregorio_google wrote:
> What is this line supposed to do?

Done.

[jcgregorio_google, 2011-10-05 12:09:20]

LGTM

[conleyo, 2011-10-05 15:29:47]

On 2011/10/05 12:09:20, jcgregorio_google wrote:
> LGTM

Anything I have to do at this point?

[jcgregorio_google, 2011-10-05 15:34:56]

Nope, I was just waiting for code hosting to get out or read-only
maintenance to commit.

  Thanks,
  -joe

On Wed, Oct 5, 2011 at 11:29 AM,  <conleyo@google.com> wrote:
> On 2011/10/05 12:09:20, jcgregorio_google wrote:
>>
>> LGTM
>
> Anything I have to do at this point?
>
> http://codereview.appspot.com/5165047/
>

[jcgregorio_google, 2011-10-05 15:38:15]

Actually, there is an issue, what version of Django is this supposed to run
against? I have 1.3.1 installed:

$ make test
python runtests.py tests
Running the tests found in the following modules:
['tests.test_http', 'tests.test_errors', 'tests.test_mocks',
'tests.test_oauth2client_django_orm', 'tests.test_model',
'tests.test_json_model', 'tests.test_oauth', 'tests.test_protobuf_model',
'tests.test_oauth2client_appengine', 'tests.test_discovery',
'tests.test_oauth2client', 'tests.test_oauth2client_file']
Traceback (most recent call last):
  File "runtests.py", line 81, in <module>
    main()
  File "runtests.py", line 70, in main
    run('tests', verbosity, exit_on_failure)
  File "runtests.py", line 43, in run
    tests = build_suite(test_folder_name, verbosity)
  File "runtests.py", line 38, in build_suite
    __import__(module)
  File
"/usr/local/google/home/jcgregorio/projects/apiclient/tests/test_oauth2client_django_orm.py",
line 39, in <module>
    from oauth2client.django_orm import CredentialsField
  File
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
line 30, in <module>
    class CredentialsField(models.Field):
  File
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
line 32, in CredentialsField
    __metaclass__ = models.SubfieldBase
AttributeError: 'module' object has no attribute 'SubfieldBase'
make: *** [test] Error 1

   -joe


On Wed, Oct 5, 2011 at 11:34 AM, Joe Gregorio <jcgregorio@google.com> wrote:

> Nope, I was just waiting for code hosting to get out or read-only
> maintenance to commit.
>
>  Thanks,
>  -joe
>
> On Wed, Oct 5, 2011 at 11:29 AM,  <conleyo@google.com> wrote:
> > On 2011/10/05 12:09:20, jcgregorio_google wrote:
> >>
> >> LGTM
> >
> > Anything I have to do at this point?
> >
> > http://codereview.appspot.com/5165047/
> >
>

[conleyo, 2011-10-05 15:50:57]

I wrote it to run against 1.2 and 1.3, so that shouldn't be happening...  I
did not run the unit tests with django 1.3 (although that is what I used to
write it so it should be fine).  I'll look into it.

On Wed, Oct 5, 2011 at 8:38 AM, Joe Gregorio <jcgregorio@google.com> wrote:

> Actually, there is an issue, what version of Django is this supposed to run
> against? I have 1.3.1 installed:
>
> $ make test
> python runtests.py tests
> Running the tests found in the following modules:
> ['tests.test_http', 'tests.test_errors', 'tests.test_mocks',
> 'tests.test_oauth2client_django_orm', 'tests.test_model',
> 'tests.test_json_model', 'tests.test_oauth', 'tests.test_protobuf_model',
> 'tests.test_oauth2client_appengine', 'tests.test_discovery',
> 'tests.test_oauth2client', 'tests.test_oauth2client_file']
> Traceback (most recent call last):
>   File "runtests.py", line 81, in <module>
>     main()
>   File "runtests.py", line 70, in main
>     run('tests', verbosity, exit_on_failure)
>   File "runtests.py", line 43, in run
>     tests = build_suite(test_folder_name, verbosity)
>   File "runtests.py", line 38, in build_suite
>     __import__(module)
>   File
>
"/usr/local/google/home/jcgregorio/projects/apiclient/tests/test_oauth2client_django_orm.py",
> line 39, in <module>
>     from oauth2client.django_orm import CredentialsField
>   File
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> line 30, in <module>
>     class CredentialsField(models.Field):
>   File
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> line 32, in CredentialsField
>     __metaclass__ = models.SubfieldBase
> AttributeError: 'module' object has no attribute 'SubfieldBase'
> make: *** [test] Error 1
>
>    -joe
>
>
> On Wed, Oct 5, 2011 at 11:34 AM, Joe Gregorio <jcgregorio@google.com>wrote:
>
>> Nope, I was just waiting for code hosting to get out or read-only
>> maintenance to commit.
>>
>>  Thanks,
>>  -joe
>>
>> On Wed, Oct 5, 2011 at 11:29 AM,  <conleyo@google.com> wrote:
>> > On 2011/10/05 12:09:20, jcgregorio_google wrote:
>> >>
>> >> LGTM
>> >
>> > Anything I have to do at this point?
>> >
>> > http://codereview.appspot.com/5165047/
>> >
>>
>
>

[conleyo, 2011-10-05 16:12:12]

On 2011/10/05 15:50:57, conleyo wrote:
> I wrote it to run against 1.2 and 1.3, so that shouldn't be happening...  I
> did not run the unit tests with django 1.3 (although that is what I used to
> write it so it should be fine).  I'll look into it.

Yea, I don't know what to tell you.  Other than some deprecation warnings
(avoided in latest patch), nothing goes wrong when running against django1.3.

Also, browsing the source, it doesn't look like they've done anything to remove
SubfieldBase.
https://code.djangoproject.com/browser/django/trunk/django/db/models/__init__.py

> 
> On Wed, Oct 5, 2011 at 8:38 AM, Joe Gregorio <mailto:jcgregorio@google.com>
wrote:
> 
> > Actually, there is an issue, what version of Django is this supposed to run
> > against? I have 1.3.1 installed:
> >
> > $ make test
> > python runtests.py tests
> > Running the tests found in the following modules:
> > ['tests.test_http', 'tests.test_errors', 'tests.test_mocks',
> > 'tests.test_oauth2client_django_orm', 'tests.test_model',
> > 'tests.test_json_model', 'tests.test_oauth', 'tests.test_protobuf_model',
> > 'tests.test_oauth2client_appengine', 'tests.test_discovery',
> > 'tests.test_oauth2client', 'tests.test_oauth2client_file']
> > Traceback (most recent call last):
> >   File "runtests.py", line 81, in <module>
> >     main()
> >   File "runtests.py", line 70, in main
> >     run('tests', verbosity, exit_on_failure)
> >   File "runtests.py", line 43, in run
> >     tests = build_suite(test_folder_name, verbosity)
> >   File "runtests.py", line 38, in build_suite
> >     __import__(module)
> >   File
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/tests/test_oauth2client_django_orm.py",
> > line 39, in <module>
> >     from oauth2client.django_orm import CredentialsField
> >   File
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > line 30, in <module>
> >     class CredentialsField(models.Field):
> >   File
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > line 32, in CredentialsField
> >     __metaclass__ = models.SubfieldBase
> > AttributeError: 'module' object has no attribute 'SubfieldBase'
> > make: *** [test] Error 1
> >
> >    -joe
> >
> >
> > On Wed, Oct 5, 2011 at 11:34 AM, Joe Gregorio <jcgregorio@google.com>wrote:
> >
> >> Nope, I was just waiting for code hosting to get out or read-only
> >> maintenance to commit.
> >>
> >>  Thanks,
> >>  -joe
> >>
> >> On Wed, Oct 5, 2011 at 11:29 AM,  <mailto:conleyo@google.com> wrote:
> >> > On 2011/10/05 12:09:20, jcgregorio_google wrote:
> >> >>
> >> >> LGTM
> >> >
> >> > Anything I have to do at this point?
> >> >
> >> > http://codereview.appspot.com/5165047/
> >> >
> >>
> >
> >

[conleyo, 2011-10-10 20:33:07]

Hi Joe.  Do you have any more info I can use to figure out why it doesn't work
for you?

On 2011/10/05 16:12:12, conleyo wrote:
> On 2011/10/05 15:50:57, conleyo wrote:
> > I wrote it to run against 1.2 and 1.3, so that shouldn't be happening...  I
> > did not run the unit tests with django 1.3 (although that is what I used to
> > write it so it should be fine).  I'll look into it.
> 
> Yea, I don't know what to tell you.  Other than some deprecation warnings
> (avoided in latest patch), nothing goes wrong when running against django1.3.
> 
> Also, browsing the source, it doesn't look like they've done anything to
remove
> SubfieldBase.
>
https://code.djangoproject.com/browser/django/trunk/django/db/models/__init__.py
> 
> > 
> > On Wed, Oct 5, 2011 at 8:38 AM, Joe Gregorio <mailto:jcgregorio@google.com>
> wrote:
> > 
> > > Actually, there is an issue, what version of Django is this supposed to
run
> > > against? I have 1.3.1 installed:
> > >
> > > $ make test
> > > python runtests.py tests
> > > Running the tests found in the following modules:
> > > ['tests.test_http', 'tests.test_errors', 'tests.test_mocks',
> > > 'tests.test_oauth2client_django_orm', 'tests.test_model',
> > > 'tests.test_json_model', 'tests.test_oauth', 'tests.test_protobuf_model',
> > > 'tests.test_oauth2client_appengine', 'tests.test_discovery',
> > > 'tests.test_oauth2client', 'tests.test_oauth2client_file']
> > > Traceback (most recent call last):
> > >   File "runtests.py", line 81, in <module>
> > >     main()
> > >   File "runtests.py", line 70, in main
> > >     run('tests', verbosity, exit_on_failure)
> > >   File "runtests.py", line 43, in run
> > >     tests = build_suite(test_folder_name, verbosity)
> > >   File "runtests.py", line 38, in build_suite
> > >     __import__(module)
> > >   File
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/tests/test_oauth2client_django_orm.py",
> > > line 39, in <module>
> > >     from oauth2client.django_orm import CredentialsField
> > >   File
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > > line 30, in <module>
> > >     class CredentialsField(models.Field):
> > >   File
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > > line 32, in CredentialsField
> > >     __metaclass__ = models.SubfieldBase
> > > AttributeError: 'module' object has no attribute 'SubfieldBase'
> > > make: *** [test] Error 1
> > >
> > >    -joe
> > >
> > >
> > > On Wed, Oct 5, 2011 at 11:34 AM, Joe Gregorio
<jcgregorio@google.com>wrote:
> > >
> > >> Nope, I was just waiting for code hosting to get out or read-only
> > >> maintenance to commit.
> > >>
> > >>  Thanks,
> > >>  -joe
> > >>
> > >> On Wed, Oct 5, 2011 at 11:29 AM,  <mailto:conleyo@google.com> wrote:
> > >> > On 2011/10/05 12:09:20, jcgregorio_google wrote:
> > >> >>
> > >> >> LGTM
> > >> >
> > >> > Anything I have to do at this point?
> > >> >
> > >> > http://codereview.appspot.com/5165047/
> > >> >
> > >>
> > >
> > >

[conleyo, 2011-10-13 21:02:17]

ping

On 2011/10/10 20:33:07, conleyo wrote:
> Hi Joe.  Do you have any more info I can use to figure out why it doesn't work
> for you?
> 
> On 2011/10/05 16:12:12, conleyo wrote:
> > On 2011/10/05 15:50:57, conleyo wrote:
> > > I wrote it to run against 1.2 and 1.3, so that shouldn't be happening... 
I
> > > did not run the unit tests with django 1.3 (although that is what I used
to
> > > write it so it should be fine).  I'll look into it.
> > 
> > Yea, I don't know what to tell you.  Other than some deprecation warnings
> > (avoided in latest patch), nothing goes wrong when running against
django1.3.
> > 
> > Also, browsing the source, it doesn't look like they've done anything to
> remove
> > SubfieldBase.
> >
>
https://code.djangoproject.com/browser/django/trunk/django/db/models/__init__.py
> > 
> > > 
> > > On Wed, Oct 5, 2011 at 8:38 AM, Joe Gregorio
<mailto:jcgregorio@google.com>
> > wrote:
> > > 
> > > > Actually, there is an issue, what version of Django is this supposed to
> run
> > > > against? I have 1.3.1 installed:
> > > >
> > > > $ make test
> > > > python runtests.py tests
> > > > Running the tests found in the following modules:
> > > > ['tests.test_http', 'tests.test_errors', 'tests.test_mocks',
> > > > 'tests.test_oauth2client_django_orm', 'tests.test_model',
> > > > 'tests.test_json_model', 'tests.test_oauth',
'tests.test_protobuf_model',
> > > > 'tests.test_oauth2client_appengine', 'tests.test_discovery',
> > > > 'tests.test_oauth2client', 'tests.test_oauth2client_file']
> > > > Traceback (most recent call last):
> > > >   File "runtests.py", line 81, in <module>
> > > >     main()
> > > >   File "runtests.py", line 70, in main
> > > >     run('tests', verbosity, exit_on_failure)
> > > >   File "runtests.py", line 43, in run
> > > >     tests = build_suite(test_folder_name, verbosity)
> > > >   File "runtests.py", line 38, in build_suite
> > > >     __import__(module)
> > > >   File
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/tests/test_oauth2client_django_orm.py",
> > > > line 39, in <module>
> > > >     from oauth2client.django_orm import CredentialsField
> > > >   File
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > > > line 30, in <module>
> > > >     class CredentialsField(models.Field):
> > > >   File
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > > > line 32, in CredentialsField
> > > >     __metaclass__ = models.SubfieldBase
> > > > AttributeError: 'module' object has no attribute 'SubfieldBase'
> > > > make: *** [test] Error 1
> > > >
> > > >    -joe
> > > >
> > > >
> > > > On Wed, Oct 5, 2011 at 11:34 AM, Joe Gregorio
> <jcgregorio@google.com>wrote:
> > > >
> > > >> Nope, I was just waiting for code hosting to get out or read-only
> > > >> maintenance to commit.
> > > >>
> > > >>  Thanks,
> > > >>  -joe
> > > >>
> > > >> On Wed, Oct 5, 2011 at 11:29 AM,  <mailto:conleyo@google.com> wrote:
> > > >> > On 2011/10/05 12:09:20, jcgregorio_google wrote:
> > > >> >>
> > > >> >> LGTM
> > > >> >
> > > >> > Anything I have to do at this point?
> > > >> >
> > > >> > http://codereview.appspot.com/5165047/
> > > >> >
> > > >>
> > > >
> > > >

[jcgregorio_google, 2011-10-14 14:15:32]

Aha, it's failing because it's picking up the Django 0.96 in App Engine. Now to
figure how to stop that from happening.

On 2011/10/13 21:02:17, conleyo wrote:
> ping
> 
> On 2011/10/10 20:33:07, conleyo wrote:
> > Hi Joe.  Do you have any more info I can use to figure out why it doesn't
work
> > for you?
> > 
> > On 2011/10/05 16:12:12, conleyo wrote:
> > > On 2011/10/05 15:50:57, conleyo wrote:
> > > > I wrote it to run against 1.2 and 1.3, so that shouldn't be happening...

> I
> > > > did not run the unit tests with django 1.3 (although that is what I used
> to
> > > > write it so it should be fine).  I'll look into it.
> > > 
> > > Yea, I don't know what to tell you.  Other than some deprecation warnings
> > > (avoided in latest patch), nothing goes wrong when running against
> django1.3.
> > > 
> > > Also, browsing the source, it doesn't look like they've done anything to
> > remove
> > > SubfieldBase.
> > >
> >
>
https://code.djangoproject.com/browser/django/trunk/django/db/models/__init__.py
> > > 
> > > > 
> > > > On Wed, Oct 5, 2011 at 8:38 AM, Joe Gregorio
> <mailto:jcgregorio@google.com>
> > > wrote:
> > > > 
> > > > > Actually, there is an issue, what version of Django is this supposed
to
> > run
> > > > > against? I have 1.3.1 installed:
> > > > >
> > > > > $ make test
> > > > > python runtests.py tests
> > > > > Running the tests found in the following modules:
> > > > > ['tests.test_http', 'tests.test_errors', 'tests.test_mocks',
> > > > > 'tests.test_oauth2client_django_orm', 'tests.test_model',
> > > > > 'tests.test_json_model', 'tests.test_oauth',
> 'tests.test_protobuf_model',
> > > > > 'tests.test_oauth2client_appengine', 'tests.test_discovery',
> > > > > 'tests.test_oauth2client', 'tests.test_oauth2client_file']
> > > > > Traceback (most recent call last):
> > > > >   File "runtests.py", line 81, in <module>
> > > > >     main()
> > > > >   File "runtests.py", line 70, in main
> > > > >     run('tests', verbosity, exit_on_failure)
> > > > >   File "runtests.py", line 43, in run
> > > > >     tests = build_suite(test_folder_name, verbosity)
> > > > >   File "runtests.py", line 38, in build_suite
> > > > >     __import__(module)
> > > > >   File
> > > > >
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/tests/test_oauth2client_django_orm.py",
> > > > > line 39, in <module>
> > > > >     from oauth2client.django_orm import CredentialsField
> > > > >   File
> > > > >
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > > > > line 30, in <module>
> > > > >     class CredentialsField(models.Field):
> > > > >   File
> > > > >
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > > > > line 32, in CredentialsField
> > > > >     __metaclass__ = models.SubfieldBase
> > > > > AttributeError: 'module' object has no attribute 'SubfieldBase'
> > > > > make: *** [test] Error 1
> > > > >
> > > > >    -joe
> > > > >
> > > > >
> > > > > On Wed, Oct 5, 2011 at 11:34 AM, Joe Gregorio
> > <jcgregorio@google.com>wrote:
> > > > >
> > > > >> Nope, I was just waiting for code hosting to get out or read-only
> > > > >> maintenance to commit.
> > > > >>
> > > > >>  Thanks,
> > > > >>  -joe
> > > > >>
> > > > >> On Wed, Oct 5, 2011 at 11:29 AM,  <mailto:conleyo@google.com> wrote:
> > > > >> > On 2011/10/05 12:09:20, jcgregorio_google wrote:
> > > > >> >>
> > > > >> >> LGTM
> > > > >> >
> > > > >> > Anything I have to do at this point?
> > > > >> >
> > > > >> > http://codereview.appspot.com/5165047/
> > > > >> >
> > > > >>
> > > > >
> > > > >

[jcgregorio_google, 2011-10-14 14:31:36]

Found a fix, please update runtests.py with:

--- a/runtests.py       Fri Oct 14 09:59:32 2011 -0400
+++ b/runtests.py       Fri Oct 14 10:30:09 2011 -0400
@@ -19,6 +19,9 @@
 sys.path.insert(0, os.getcwd())
 sys.path.insert(0, APP_ENGINE_PATH)
 
+from google.appengine.dist import use_library
+use_library('django', '1.2')
+
 def build_suite(folder, verbosity):
   # find all of the test modules
   top_level_modules = map(fullmodname, glob.glob(os.path.join(folder,
'test_*.py')))



On 2011/10/14 14:15:32, jcgregorio_google wrote:
> Aha, it's failing because it's picking up the Django 0.96 in App Engine. Now
to
> figure how to stop that from happening.
> 
> On 2011/10/13 21:02:17, conleyo wrote:
> > ping
> > 
> > On 2011/10/10 20:33:07, conleyo wrote:
> > > Hi Joe.  Do you have any more info I can use to figure out why it doesn't
> work
> > > for you?
> > > 
> > > On 2011/10/05 16:12:12, conleyo wrote:
> > > > On 2011/10/05 15:50:57, conleyo wrote:
> > > > > I wrote it to run against 1.2 and 1.3, so that shouldn't be
happening...
> 
> > I
> > > > > did not run the unit tests with django 1.3 (although that is what I
used
> > to
> > > > > write it so it should be fine).  I'll look into it.
> > > > 
> > > > Yea, I don't know what to tell you.  Other than some deprecation
warnings
> > > > (avoided in latest patch), nothing goes wrong when running against
> > django1.3.
> > > > 
> > > > Also, browsing the source, it doesn't look like they've done anything to
> > > remove
> > > > SubfieldBase.
> > > >
> > >
> >
>
https://code.djangoproject.com/browser/django/trunk/django/db/models/__init__.py
> > > > 
> > > > > 
> > > > > On Wed, Oct 5, 2011 at 8:38 AM, Joe Gregorio
> > <mailto:jcgregorio@google.com>
> > > > wrote:
> > > > > 
> > > > > > Actually, there is an issue, what version of Django is this supposed
> to
> > > run
> > > > > > against? I have 1.3.1 installed:
> > > > > >
> > > > > > $ make test
> > > > > > python runtests.py tests
> > > > > > Running the tests found in the following modules:
> > > > > > ['tests.test_http', 'tests.test_errors', 'tests.test_mocks',
> > > > > > 'tests.test_oauth2client_django_orm', 'tests.test_model',
> > > > > > 'tests.test_json_model', 'tests.test_oauth',
> > 'tests.test_protobuf_model',
> > > > > > 'tests.test_oauth2client_appengine', 'tests.test_discovery',
> > > > > > 'tests.test_oauth2client', 'tests.test_oauth2client_file']
> > > > > > Traceback (most recent call last):
> > > > > >   File "runtests.py", line 81, in <module>
> > > > > >     main()
> > > > > >   File "runtests.py", line 70, in main
> > > > > >     run('tests', verbosity, exit_on_failure)
> > > > > >   File "runtests.py", line 43, in run
> > > > > >     tests = build_suite(test_folder_name, verbosity)
> > > > > >   File "runtests.py", line 38, in build_suite
> > > > > >     __import__(module)
> > > > > >   File
> > > > > >
> > > > >
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/tests/test_oauth2client_django_orm.py",
> > > > > > line 39, in <module>
> > > > > >     from oauth2client.django_orm import CredentialsField
> > > > > >   File
> > > > > >
> > > > >
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > > > > > line 30, in <module>
> > > > > >     class CredentialsField(models.Field):
> > > > > >   File
> > > > > >
> > > > >
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > > > > > line 32, in CredentialsField
> > > > > >     __metaclass__ = models.SubfieldBase
> > > > > > AttributeError: 'module' object has no attribute 'SubfieldBase'
> > > > > > make: *** [test] Error 1
> > > > > >
> > > > > >    -joe
> > > > > >
> > > > > >
> > > > > > On Wed, Oct 5, 2011 at 11:34 AM, Joe Gregorio
> > > <jcgregorio@google.com>wrote:
> > > > > >
> > > > > >> Nope, I was just waiting for code hosting to get out or read-only
> > > > > >> maintenance to commit.
> > > > > >>
> > > > > >>  Thanks,
> > > > > >>  -joe
> > > > > >>
> > > > > >> On Wed, Oct 5, 2011 at 11:29 AM,  <mailto:conleyo@google.com>
wrote:
> > > > > >> > On 2011/10/05 12:09:20, jcgregorio_google wrote:
> > > > > >> >>
> > > > > >> >> LGTM
> > > > > >> >
> > > > > >> > Anything I have to do at this point?
> > > > > >> >
> > > > > >> > http://codereview.appspot.com/5165047/
> > > > > >> >
> > > > > >>
> > > > > >
> > > > > >

[conleyo, 2011-10-14 16:15:49]

I made the fix but I'm having trouble running authenticating in upload-diffs. 
Is there some authentication trick I'm forgetting?

On 2011/10/14 14:31:36, jcgregorio_google wrote:
> Found a fix, please update runtests.py with:
> 
> --- a/runtests.py       Fri Oct 14 09:59:32 2011 -0400
> +++ b/runtests.py       Fri Oct 14 10:30:09 2011 -0400
> @@ -19,6 +19,9 @@
>  sys.path.insert(0, os.getcwd())
>  sys.path.insert(0, APP_ENGINE_PATH)
>  
> +from google.appengine.dist import use_library
> +use_library('django', '1.2')
> +
>  def build_suite(folder, verbosity):
>    # find all of the test modules
>    top_level_modules = map(fullmodname, glob.glob(os.path.join(folder,
> 'test_*.py')))
> 
> 
> 
> On 2011/10/14 14:15:32, jcgregorio_google wrote:
> > Aha, it's failing because it's picking up the Django 0.96 in App Engine. Now
> to
> > figure how to stop that from happening.
> > 
> > On 2011/10/13 21:02:17, conleyo wrote:
> > > ping
> > > 
> > > On 2011/10/10 20:33:07, conleyo wrote:
> > > > Hi Joe.  Do you have any more info I can use to figure out why it
doesn't
> > work
> > > > for you?
> > > > 
> > > > On 2011/10/05 16:12:12, conleyo wrote:
> > > > > On 2011/10/05 15:50:57, conleyo wrote:
> > > > > > I wrote it to run against 1.2 and 1.3, so that shouldn't be
> happening...
> > 
> > > I
> > > > > > did not run the unit tests with django 1.3 (although that is what I
> used
> > > to
> > > > > > write it so it should be fine).  I'll look into it.
> > > > > 
> > > > > Yea, I don't know what to tell you.  Other than some deprecation
> warnings
> > > > > (avoided in latest patch), nothing goes wrong when running against
> > > django1.3.
> > > > > 
> > > > > Also, browsing the source, it doesn't look like they've done anything
to
> > > > remove
> > > > > SubfieldBase.
> > > > >
> > > >
> > >
> >
>
https://code.djangoproject.com/browser/django/trunk/django/db/models/__init__.py
> > > > > 
> > > > > > 
> > > > > > On Wed, Oct 5, 2011 at 8:38 AM, Joe Gregorio
> > > <mailto:jcgregorio@google.com>
> > > > > wrote:
> > > > > > 
> > > > > > > Actually, there is an issue, what version of Django is this
supposed
> > to
> > > > run
> > > > > > > against? I have 1.3.1 installed:
> > > > > > >
> > > > > > > $ make test
> > > > > > > python runtests.py tests
> > > > > > > Running the tests found in the following modules:
> > > > > > > ['tests.test_http', 'tests.test_errors', 'tests.test_mocks',
> > > > > > > 'tests.test_oauth2client_django_orm', 'tests.test_model',
> > > > > > > 'tests.test_json_model', 'tests.test_oauth',
> > > 'tests.test_protobuf_model',
> > > > > > > 'tests.test_oauth2client_appengine', 'tests.test_discovery',
> > > > > > > 'tests.test_oauth2client', 'tests.test_oauth2client_file']
> > > > > > > Traceback (most recent call last):
> > > > > > >   File "runtests.py", line 81, in <module>
> > > > > > >     main()
> > > > > > >   File "runtests.py", line 70, in main
> > > > > > >     run('tests', verbosity, exit_on_failure)
> > > > > > >   File "runtests.py", line 43, in run
> > > > > > >     tests = build_suite(test_folder_name, verbosity)
> > > > > > >   File "runtests.py", line 38, in build_suite
> > > > > > >     __import__(module)
> > > > > > >   File
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/tests/test_oauth2client_django_orm.py",
> > > > > > > line 39, in <module>
> > > > > > >     from oauth2client.django_orm import CredentialsField
> > > > > > >   File
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > > > > > > line 30, in <module>
> > > > > > >     class CredentialsField(models.Field):
> > > > > > >   File
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> > > > > > > line 32, in CredentialsField
> > > > > > >     __metaclass__ = models.SubfieldBase
> > > > > > > AttributeError: 'module' object has no attribute 'SubfieldBase'
> > > > > > > make: *** [test] Error 1
> > > > > > >
> > > > > > >    -joe
> > > > > > >
> > > > > > >
> > > > > > > On Wed, Oct 5, 2011 at 11:34 AM, Joe Gregorio
> > > > <jcgregorio@google.com>wrote:
> > > > > > >
> > > > > > >> Nope, I was just waiting for code hosting to get out or read-only
> > > > > > >> maintenance to commit.
> > > > > > >>
> > > > > > >>  Thanks,
> > > > > > >>  -joe
> > > > > > >>
> > > > > > >> On Wed, Oct 5, 2011 at 11:29 AM,  <mailto:conleyo@google.com>
> wrote:
> > > > > > >> > On 2011/10/05 12:09:20, jcgregorio_google wrote:
> > > > > > >> >>
> > > > > > >> >> LGTM
> > > > > > >> >
> > > > > > >> > Anything I have to do at this point?
> > > > > > >> >
> > > > > > >> > http://codereview.appspot.com/5165047/
> > > > > > >> >
> > > > > > >>
> > > > > > >
> > > > > > >

[jcgregorio_google, 2011-10-14 17:30:30]

You probably have 2-step auth turned on for you account, which means you
need to use an application specific password:

  https://accounts.google.com/b/0/IssuedAuthSubTokens

On Fri, Oct 14, 2011 at 12:15 PM,  <conleyo@google.com> wrote:
> I made the fix but I'm having trouble running authenticating in
> upload-diffs.  Is there some authentication trick I'm forgetting?
>
> On 2011/10/14 14:31:36, jcgregorio_google wrote:
>>
>> Found a fix, please update runtests.py with:
>
>> --- a/runtests.py       Fri Oct 14 09:59:32 2011 -0400
>> +++ b/runtests.py       Fri Oct 14 10:30:09 2011 -0400
>> @@ -19,6 +19,9 @@
>>  sys.path.insert(0, os.getcwd())
>>  sys.path.insert(0, APP_ENGINE_PATH)
>
>> +from google.appengine.dist import use_library
>> +use_library('django', '1.2')
>> +
>>  def build_suite(folder, verbosity):
>>    # find all of the test modules
>>    top_level_modules = map(fullmodname, glob.glob(os.path.join(folder,
>> 'test_*.py')))
>
>
>
>> On 2011/10/14 14:15:32, jcgregorio_google wrote:
>> > Aha, it's failing because it's picking up the Django 0.96 in App
>
> Engine. Now
>>
>> to
>> > figure how to stop that from happening.
>> >
>> > On 2011/10/13 21:02:17, conleyo wrote:
>> > > ping
>> > >
>> > > On 2011/10/10 20:33:07, conleyo wrote:
>> > > > Hi Joe.  Do you have any more info I can use to figure out why
>
> it doesn't
>>
>> > work
>> > > > for you?
>> > > >
>> > > > On 2011/10/05 16:12:12, conleyo wrote:
>> > > > > On 2011/10/05 15:50:57, conleyo wrote:
>> > > > > > I wrote it to run against 1.2 and 1.3, so that shouldn't be
>> happening...
>> >
>> > > I
>> > > > > > did not run the unit tests with django 1.3 (although that is
>
> what I
>>
>> used
>> > > to
>> > > > > > write it so it should be fine).  I'll look into it.
>> > > > >
>> > > > > Yea, I don't know what to tell you.  Other than some
>
> deprecation
>>
>> warnings
>> > > > > (avoided in latest patch), nothing goes wrong when running
>
> against
>>
>> > > django1.3.
>> > > > >
>> > > > > Also, browsing the source, it doesn't look like they've done
>
> anything to
>>
>> > > > remove
>> > > > > SubfieldBase.
>> > > > >
>> > > >
>> > >
>> >
>
>
https://code.djangoproject.com/browser/django/trunk/django/db/models/__init__.py
>>
>> > > > >
>> > > > > >
>> > > > > > On Wed, Oct 5, 2011 at 8:38 AM, Joe Gregorio
>> > > <mailto:jcgregorio@google.com>
>> > > > > wrote:
>> > > > > >
>> > > > > > > Actually, there is an issue, what version of Django is
>
> this supposed
>>
>> > to
>> > > > run
>> > > > > > > against? I have 1.3.1 installed:
>> > > > > > >
>> > > > > > > $ make test
>> > > > > > > python runtests.py tests
>> > > > > > > Running the tests found in the following modules:
>> > > > > > > ['tests.test_http', 'tests.test_errors',
>
> 'tests.test_mocks',
>>
>> > > > > > > 'tests.test_oauth2client_django_orm', 'tests.test_model',
>> > > > > > > 'tests.test_json_model', 'tests.test_oauth',
>> > > 'tests.test_protobuf_model',
>> > > > > > > 'tests.test_oauth2client_appengine',
>
> 'tests.test_discovery',
>>
>> > > > > > > 'tests.test_oauth2client', 'tests.test_oauth2client_file']
>> > > > > > > Traceback (most recent call last):
>> > > > > > >   File "runtests.py", line 81, in <module>
>> > > > > > >     main()
>> > > > > > >   File "runtests.py", line 70, in main
>> > > > > > >     run('tests', verbosity, exit_on_failure)
>> > > > > > >   File "runtests.py", line 43, in run
>> > > > > > >     tests = build_suite(test_folder_name, verbosity)
>> > > > > > >   File "runtests.py", line 38, in build_suite
>> > > > > > >     __import__(module)
>> > > > > > >   File
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>
>
"/usr/local/google/home/jcgregorio/projects/apiclient/tests/test_oauth2client_django_orm.py",
>>
>> > > > > > > line 39, in <module>
>> > > > > > >     from oauth2client.django_orm import CredentialsField
>> > > > > > >   File
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
>>
>> > > > > > > line 30, in <module>
>> > > > > > >     class CredentialsField(models.Field):
>> > > > > > >   File
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
>>
>> > > > > > > line 32, in CredentialsField
>> > > > > > >     __metaclass__ = models.SubfieldBase
>> > > > > > > AttributeError: 'module' object has no attribute
>
> 'SubfieldBase'
>>
>> > > > > > > make: *** [test] Error 1
>> > > > > > >
>> > > > > > >    -joe
>> > > > > > >
>> > > > > > >
>> > > > > > > On Wed, Oct 5, 2011 at 11:34 AM, Joe Gregorio
>> > > > <jcgregorio@google.com>wrote:
>> > > > > > >
>> > > > > > >> Nope, I was just waiting for code hosting to get out or
>
> read-only
>>
>> > > > > > >> maintenance to commit.
>> > > > > > >>
>> > > > > > >>  Thanks,
>> > > > > > >>  -joe
>> > > > > > >>
>> > > > > > >> On Wed, Oct 5, 2011 at 11:29 AM,
>
> <mailto:conleyo@google.com>
>>
>> wrote:
>> > > > > > >> > On 2011/10/05 12:09:20, jcgregorio_google wrote:
>> > > > > > >> >>
>> > > > > > >> >> LGTM
>> > > > > > >> >
>> > > > > > >> > Anything I have to do at this point?
>> > > > > > >> >
>> > > > > > >> > http://codereview.appspot.com/5165047/
>> > > > > > >> >
>> > > > > > >>
>> > > > > > >
>> > > > > > >
>
>
>
> http://codereview.appspot.com/5165047/
>

[conleyo, 2011-10-14 17:48:22]

Ok, we're good now.

On 2011/10/14 17:30:30, jcgregorio_google wrote:
> You probably have 2-step auth turned on for you account, which means you
> need to use an application specific password:
> 
>   https://accounts.google.com/b/0/IssuedAuthSubTokens
> 
> On Fri, Oct 14, 2011 at 12:15 PM,  <mailto:conleyo@google.com> wrote:
> > I made the fix but I'm having trouble running authenticating in
> > upload-diffs. &nbsp;Is there some authentication trick I'm forgetting?
> >
> > On 2011/10/14 14:31:36, jcgregorio_google wrote:
> >>
> >> Found a fix, please update runtests.py with:
> >
> >> --- a/runtests.py &nbsp; &nbsp; &nbsp; Fri Oct 14 09:59:32 2011 -0400
> >> +++ b/runtests.py &nbsp; &nbsp; &nbsp; Fri Oct 14 10:30:09 2011 -0400
> >> @@ -19,6 +19,9 @@
> >> &nbsp;sys.path.insert(0, os.getcwd())
> >> &nbsp;sys.path.insert(0, APP_ENGINE_PATH)
> >
> >> +from google.appengine.dist import use_library
> >> +use_library('django', '1.2')
> >> +
> >> &nbsp;def build_suite(folder, verbosity):
> >> &nbsp; &nbsp;# find all of the test modules
> >> &nbsp; &nbsp;top_level_modules = map(fullmodname,
glob.glob(os.path.join(folder,
> >> 'test_*.py')))
> >
> >
> >
> >> On 2011/10/14 14:15:32, jcgregorio_google wrote:
> >> > Aha, it's failing because it's picking up the Django 0.96 in App
> >
> > Engine. Now
> >>
> >> to
> >> > figure how to stop that from happening.
> >> >
> >> > On 2011/10/13 21:02:17, conleyo wrote:
> >> > > ping
> >> > >
> >> > > On 2011/10/10 20:33:07, conleyo wrote:
> >> > > > Hi Joe. &nbsp;Do you have any more info I can use to figure out why
> >
> > it doesn't
> >>
> >> > work
> >> > > > for you?
> >> > > >
> >> > > > On 2011/10/05 16:12:12, conleyo wrote:
> >> > > > > On 2011/10/05 15:50:57, conleyo wrote:
> >> > > > > > I wrote it to run against 1.2 and 1.3, so that shouldn't be
> >> happening...
> >> >
> >> > > I
> >> > > > > > did not run the unit tests with django 1.3 (although that is
> >
> > what I
> >>
> >> used
> >> > > to
> >> > > > > > write it so it should be fine). &nbsp;I'll look into it.
> >> > > > >
> >> > > > > Yea, I don't know what to tell you. &nbsp;Other than some
> >
> > deprecation
> >>
> >> warnings
> >> > > > > (avoided in latest patch), nothing goes wrong when running
> >
> > against
> >>
> >> > > django1.3.
> >> > > > >
> >> > > > > Also, browsing the source, it doesn't look like they've done
> >
> > anything to
> >>
> >> > > > remove
> >> > > > > SubfieldBase.
> >> > > > >
> >> > > >
> >> > >
> >> >
> >
> >
>
https://code.djangoproject.com/browser/django/trunk/django/db/models/__init__.py
> >>
> >> > > > >
> >> > > > > >
> >> > > > > > On Wed, Oct 5, 2011 at 8:38 AM, Joe Gregorio
> >> > > <mailto:jcgregorio@google.com>
> >> > > > > wrote:
> >> > > > > >
> >> > > > > > > Actually, there is an issue, what version of Django is
> >
> > this supposed
> >>
> >> > to
> >> > > > run
> >> > > > > > > against? I have 1.3.1 installed:
> >> > > > > > >
> >> > > > > > > $ make test
> >> > > > > > > python runtests.py tests
> >> > > > > > > Running the tests found in the following modules:
> >> > > > > > > ['tests.test_http', 'tests.test_errors',
> >
> > 'tests.test_mocks',
> >>
> >> > > > > > > 'tests.test_oauth2client_django_orm', 'tests.test_model',
> >> > > > > > > 'tests.test_json_model', 'tests.test_oauth',
> >> > > 'tests.test_protobuf_model',
> >> > > > > > > 'tests.test_oauth2client_appengine',
> >
> > 'tests.test_discovery',
> >>
> >> > > > > > > 'tests.test_oauth2client', 'tests.test_oauth2client_file']
> >> > > > > > > Traceback (most recent call last):
> >> > > > > > > &nbsp; File "runtests.py", line 81, in <module>
> >> > > > > > > &nbsp; &nbsp; main()
> >> > > > > > > &nbsp; File "runtests.py", line 70, in main
> >> > > > > > > &nbsp; &nbsp; run('tests', verbosity, exit_on_failure)
> >> > > > > > > &nbsp; File "runtests.py", line 43, in run
> >> > > > > > > &nbsp; &nbsp; tests = build_suite(test_folder_name, verbosity)
> >> > > > > > > &nbsp; File "runtests.py", line 38, in build_suite
> >> > > > > > > &nbsp; &nbsp; __import__(module)
> >> > > > > > > &nbsp; File
> >> > > > > > >
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/tests/test_oauth2client_django_orm.py",
> >>
> >> > > > > > > line 39, in <module>
> >> > > > > > > &nbsp; &nbsp; from oauth2client.django_orm import
CredentialsField
> >> > > > > > > &nbsp; File
> >> > > > > > >
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> >>
> >> > > > > > > line 30, in <module>
> >> > > > > > > &nbsp; &nbsp; class CredentialsField(models.Field):
> >> > > > > > > &nbsp; File
> >> > > > > > >
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >
> >
>
"/usr/local/google/home/jcgregorio/projects/apiclient/oauth2client/django_orm.py",
> >>
> >> > > > > > > line 32, in CredentialsField
> >> > > > > > > &nbsp; &nbsp; __metaclass__ = models.SubfieldBase
> >> > > > > > > AttributeError: 'module' object has no attribute
> >
> > 'SubfieldBase'
> >>
> >> > > > > > > make: *** [test] Error 1
> >> > > > > > >
> >> > > > > > > &nbsp; &nbsp;-joe
> >> > > > > > >
> >> > > > > > >
> >> > > > > > > On Wed, Oct 5, 2011 at 11:34 AM, Joe Gregorio
> >> > > > <jcgregorio@google.com>wrote:
> >> > > > > > >
> >> > > > > > >> Nope, I was just waiting for code hosting to get out or
> >
> > read-only
> >>
> >> > > > > > >> maintenance to commit.
> >> > > > > > >>
> >> > > > > > >> &nbsp;Thanks,
> >> > > > > > >> &nbsp;-joe
> >> > > > > > >>
> >> > > > > > >> On Wed, Oct 5, 2011 at 11:29 AM,
> >
> > <mailto:conleyo@google.com>
> >>
> >> wrote:
> >> > > > > > >> > On 2011/10/05 12:09:20, jcgregorio_google wrote:
> >> > > > > > >> >>
> >> > > > > > >> >> LGTM
> >> > > > > > >> >
> >> > > > > > >> > Anything I have to do at this point?
> >> > > > > > >> >
> >> > > > > > >> > http://codereview.appspot.com/5165047/
> >> > > > > > >> >
> >> > > > > > >>
> >> > > > > > >
> >> > > > > > >
> >
> >
> >
> > http://codereview.appspot.com/5165047/
> >

[jcgregorio_google, 2011-10-14 17:54:02]

LGTM

[jcgregorio_google, 2011-10-14 17:56:02]

On 2011/10/14 17:54:02, jcgregorio_google wrote:
> LGTM

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=d16460395f3...