LSR: Updated snippet for MMR Positions (1931)

LSR: Updated snippet for MMR Positions (1931)

Removed statement that default MMR position was #0 (it is actually #2)

Added some examples of the overrides and clarified some comments
including adding new example of more than two voices

[Trevor Daniels, 2011-10-01 21:19:49]

A couple of nitpicks, otherwise LGTM (but untested).

(I'll abandon my patch - yours is better :)

Trevor

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
File Documentation/snippets/new/positioning-multi-measure-rests.ly (right):

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
Documentation/snippets/new/positioning-multi-measure-rests.ly:1: \version
"2.14.0"
2.15.14

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
Documentation/snippets/new/positioning-multi-measure-rests.ly:57: %
Multi-Measure Rest by default are set under the fourth line
% Multi-measure rests ...

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
Documentation/snippets/new/positioning-multi-measure-rests.ly:77: % Both voices
with a Multi Measure Rest
% Multi-measure rests in both voices remain separate

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
Documentation/snippets/new/positioning-multi-measure-rests.ly:80: % More that
two voices with a Multi Measure Rest require an override
% Separating multi-measure rests in more than two voices requires an override

[Graham Percival (old account), 2011-10-02 10:14:50]

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
File Documentation/snippets/new/positioning-multi-measure-rests.ly (right):

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
Documentation/snippets/new/positioning-multi-measure-rests.ly:1: \version
"2.14.0"
On 2011/10/01 21:19:50, Trevor Daniels wrote:
> 2.15.14

I didn't read the history, but is this a clarification of old program behavior,
or something new since 2.15.13 ?  I took a quick glance at the git changelog and
I didn't see anything about multi-measure rests since 2.15.13, so I don't think
the version string needs to be 2.15.14.  I'm not certain it needs to change at
all, actually.

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
Documentation/snippets/new/positioning-multi-measure-rests.ly:8: texidoces = "
Do we normally have translations in here?  I thought they normally went in
places like es/texidocs/

[Graham Percival (old account), 2011-10-02 10:18:12]

wait a moment, why are you adding a snippet to git at all?  Just fix it in LSR. 
Talk to Phil if you don't know how.

Patch rejected, sorry.


(wow, what a disaster the whole LSR thing is!)

[Trevor Daniels, 2011-10-02 15:08:09]

This is to illustrate a change introduced in
e75f38b1a9adaf7752ced683fff0e6ec01bd8a13, which
appeared first in 2.13.63 and therefore made it
into 2.14.  So James was right to have 
\release "2.14.0".  But why not just dump it in
snippets/new rather than mess around with LSR,
especially as it won't compile properly in 2.12?

Trevor

[Graham Percival (old account), 2011-10-02 15:23:59]

ok, fair enough.  By now LSR *should* be running 2.14, but since it's not I
guess we need to limp along with documentation/snippets/new/.

sigh

[pkx166h, 2011-10-06 19:55:24]

Nitpicks done. I'm still not sure of the process here

Do I need to delete the file in ../snippets/.. and then re-rerun makelsr.py, or
what?

Also I guess we need to get phil to remove this deprecated snippet from the LSR
itself so it doesn't clobber this in git or doesn't it work like that?

Thanks

James

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
File Documentation/snippets/new/positioning-multi-measure-rests.ly (right):

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
Documentation/snippets/new/positioning-multi-measure-rests.ly:57: %
Multi-Measure Rest by default are set under the fourth line
On 2011/10/01 21:19:50, Trevor Daniels wrote:
> % Multi-measure rests ...

Done.

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
Documentation/snippets/new/positioning-multi-measure-rests.ly:77: % Both voices
with a Multi Measure Rest
On 2011/10/01 21:19:50, Trevor Daniels wrote:
> % Multi-measure rests in both voices remain separate

Done.

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/posit...
Documentation/snippets/new/positioning-multi-measure-rests.ly:80: % More that
two voices with a Multi Measure Rest require an override
On 2011/10/01 21:19:50, Trevor Daniels wrote:
> % Separating multi-measure rests in more than two voices requires an override

Done.

[t.daniels_treda.co.uk, 2011-10-06 21:47:19]

James, you wrote Thursday, October 06, 2011 8:55 PM

> Do I need to delete the file in ../snippets/.. and then re-rerun
> makelsr.py, or what?

There's no need to delete it as the snippet
in /new takes precedence.

> Also I guess we need to get phil to remove this deprecated snippet 
> from
> the LSR itself so it doesn't clobber this in git or doesn't it 
> work like
> that?

I'd leave it there.  The LSR runs 2.12, and the snippet
is correct for 2.12.  It won't affect the new snippet in
/new.

(I'm sure Graham or Neil will correct this if what
I've said is wrong.)

Trevor

[Graham Percival (old account), 2011-10-07 21:29:58]

LGTM

[pkx166h, 2011-10-08 06:12:36]

Had problems uploading new patch to Rietveld after I ran makelsr.py - there are
60+ files changed (all the comittishes for the translations) - patch applies but
my internet connection seems to be flakey and/or Rietveld is unforgiving it
seems. I want to check that this is ok (with all those files changed).

Patch attached here.

http://code.google.com/p/lilypond/issues/detail?id=1931#c11

[Graham Percival (old account), 2011-10-10 13:05:27]

yes, fine, LGTM, push it.