Fix some VS2010 warnings

[bsalomon, 2011-09-29 13:27:44]

I recently enabled a higher warning level on the windows build. This fixes some
of the new warnings.

[TomH, 2011-09-29 15:05:32]

Mostly LGTM. Yay for higher warning level + removing warnings.

http://codereview.appspot.com/5155043/diff/2001/gpu/src/GrGpuGL.cpp
File gpu/src/GrGpuGL.cpp (right):

http://codereview.appspot.com/5155043/diff/2001/gpu/src/GrGpuGL.cpp#newcode435
gpu/src/GrGpuGL.cpp:435: fCaps.fNPOTRenderTargetSupport = 0 !=
expectNPOTTargets;
Could we get parentheses here for clarity?

http://codereview.appspot.com/5155043/diff/2001/src/utils/SkMatrix44.cpp
File src/utils/SkMatrix44.cpp (right):

http://codereview.appspot.com/5155043/diff/2001/src/utils/SkMatrix44.cpp#newc...
src/utils/SkMatrix44.cpp:192: SkDoubleToMScalar(zxC + ys),  
SkDoubleToMScalar(yzC - xs),   SkDoubleToMScalar(z * zC + c));
Line length? (And yeah, I know 3x3 is clear, but...)

[bsalomon, 2011-09-29 15:12:31]

http://codereview.appspot.com/5155043/diff/2001/gpu/src/GrGpuGL.cpp
File gpu/src/GrGpuGL.cpp (right):

http://codereview.appspot.com/5155043/diff/2001/gpu/src/GrGpuGL.cpp#newcode435
gpu/src/GrGpuGL.cpp:435: fCaps.fNPOTRenderTargetSupport = 0 !=
expectNPOTTargets;
On 2011/09/29 15:05:37, TomH wrote:
> Could we get parentheses here for clarity?

Done.

http://codereview.appspot.com/5155043/diff/2001/src/utils/SkMatrix44.cpp
File src/utils/SkMatrix44.cpp (right):

http://codereview.appspot.com/5155043/diff/2001/src/utils/SkMatrix44.cpp#newc...
src/utils/SkMatrix44.cpp:192: SkDoubleToMScalar(zxC + ys),  
SkDoubleToMScalar(yzC - xs),   SkDoubleToMScalar(z * zC + c));
On 2011/09/29 15:05:37, TomH wrote:
> Line length? (And yeah, I know 3x3 is clear, but...)

Done.

[reed1, 2011-09-30 12:01:27]

LGTM with nits

http://codereview.appspot.com/5155043/diff/6001/gpu/src/GrGLProgram.h
File gpu/src/GrGLProgram.h (left):

http://codereview.appspot.com/5155043/diff/6001/gpu/src/GrGLProgram.h#oldcode123
gpu/src/GrGLProgram.h:123: return fOptFlags & kIsEnabled_OptFlagBit;
or

return SkToBool(fOptFlags & kIsEnabled_OptFlagBit);

http://codereview.appspot.com/5155043/diff/6001/gpu/src/GrGpuGLShaders.cpp
File gpu/src/GrGpuGLShaders.cpp (right):

http://codereview.appspot.com/5155043/diff/6001/gpu/src/GrGpuGLShaders.cpp#ne...
gpu/src/GrGpuGLShaders.cpp:225: pdesc.fEdgeAANumEdges =
SkToS8(...) might be better, since it tests for overflow (in the debug build).

http://codereview.appspot.com/5155043/diff/6001/src/animator/SkScriptTokenize...
File src/animator/SkScriptTokenizer.cpp (left):

http://codereview.appspot.com/5155043/diff/6001/src/animator/SkScriptTokenize...
src/animator/SkScriptTokenizer.cpp:606: SkScriptValue2 scriptValue;
put the ; inside the parens

[bsalomon, 2011-10-03 13:22:13]

Checked in at r2380, nits fixed in r2393.