Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(221)

Issue 5144046: Add debug trap to gather useful info in crash. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by arthurhsu
Modified:
13 years, 2 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add debug trap to gather useful info in crash. BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : Update per code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/ports/SkFontHost_win.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5
arthurhsu
Reed's last change removed the assertions. Also, SkASSERT is translated to blank in Release mode ...
13 years, 3 months ago (2011-09-27 18:52:58 UTC) #1
Steve VanDeBogart
On 2011/09/27 18:52:58, arthurhsu wrote: > Reed's last change removed the assertions. Also, SkASSERT is ...
13 years, 3 months ago (2011-09-27 18:54:42 UTC) #2
reed1
+1 -- please be sure these are removed soon. Perhaps they can be bracketed with ...
13 years, 3 months ago (2011-09-27 19:03:40 UTC) #3
arthurhsu
Done.
13 years, 3 months ago (2011-09-27 19:44:48 UTC) #4
Steve VanDeBogart
13 years, 3 months ago (2011-09-27 19:50:20 UTC) #5
On 2011/09/27 19:44:48, arthurhsu wrote:
> Done.

Committed as r2344
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b