Reed's last change removed the assertions. Also, SkASSERT is translated to blank in Release mode ...
13 years, 1 month ago
(2011-09-27 18:52:58 UTC)
#1
Reed's last change removed the assertions. Also, SkASSERT is translated to
blank in Release mode so that the original intent to gather more useful info in
crash was in vain.
Use SK_DEBUGBREAK instead since it will trigger a debug break in Release mode.
On 2011/09/27 18:52:58, arthurhsu wrote: > Reed's last change removed the assertions. Also, SkASSERT is ...
13 years, 1 month ago
(2011-09-27 18:54:42 UTC)
#2
On 2011/09/27 18:52:58, arthurhsu wrote:
> Reed's last change removed the assertions. Also, SkASSERT is translated to
> blank in Release mode so that the original intent to gather more useful info
in
> crash was in vain.
>
> Use SK_DEBUGBREAK instead since it will trigger a debug break in Release mode.
Add a TODO to remove after you've fixed the bug (include the url)
+1 -- please be sure these are removed soon. Perhaps they can be bracketed with ...
13 years, 1 month ago
(2011-09-27 19:03:40 UTC)
#3
+1 -- please be sure these are removed soon. Perhaps they can be bracketed with
an #ifdef or something, to help document all of the asserts that you plan to
remove...
Issue 5144046: Add debug trap to gather useful info in crash.
(Closed)
Created 13 years, 1 month ago by arthurhsu
Modified 13 years, 1 month ago
Reviewers: Steve VanDeBogart, reed1
Base URL: http://skia.googlecode.com/svn/trunk
Comments: 0