Issue 5144046: Add debug trap to gather useful info in crash.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5144046: Add debug trap to gather useful info in crash. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by arthurhsu

Modified:
12 years, 11 months ago

Reviewers:
Steve VanDeBogart, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Add debug trap to gather useful info in crash. BUG=none TEST=none

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	src/ports/SkFontHost_win.cpp	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 5

arthurhsu

Reed's last change removed the assertions. Also, SkASSERT is translated to blank in Release mode ...

12 years, 11 months ago (2011-09-27 18:52:58 UTC) #1

Steve VanDeBogart

On 2011/09/27 18:52:58, arthurhsu wrote: > Reed's last change removed the assertions. Also, SkASSERT is ...

12 years, 11 months ago (2011-09-27 18:54:42 UTC) #2

reed1

+1 -- please be sure these are removed soon. Perhaps they can be bracketed with ...

12 years, 11 months ago (2011-09-27 19:03:40 UTC) #3

Steve VanDeBogart

12 years, 11 months ago (2011-09-27 19:50:20 UTC) #5

On 2011/09/27 19:44:48, arthurhsu wrote:
> Done.

Committed as r2344