Fixes to projecthosting_upload.py

Fixes to projecthosting_upload.py

[MikeSol, 2011-09-27 07:34:11]

Here are some proposed changes to porjecthosting_upload.py that should help
avoid spurious issue creation.

Graham - is there a good way to test this code w/o creating issues on the
tracker, and is there a way I can have push access to your repo on github so
that I can push any changes once you've looked them over.

Cheers,
MS

[Graham Percival (old account), 2011-09-27 08:39:45]

I'll need a github account name from you to enable random pushing to my git-cl
repo.
  https://github.com/

I'm not going to picky about applying changes to this repo... although maybe
it's good for me to take a quick peek at whatever you do, given some of the
problems below.  :)

http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py
File projecthosting_upload.py (right):

http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
projecthosting_upload.py:18: try :
4-space indents please

http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
projecthosting_upload.py:28: #PROJECT_NAME = "mewes"
To test this, comment the "mewes" line and comment out the lilypond line.

http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
projecthosting_upload.py:108: maybe_number = [int(x) for x in
re.findall(r'[0-9]+', text)]
this finds any number; I'd like to restrict the numbers to "issue" / "fix" (with
any capitalization), and maybe stuff like (123).

I certainly think we should avoid things like "According to Stone 1994, beams
should have 3 staff spaces (fix 1234)" picking up 1994.

http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
projecthosting_upload.py:111: return str(issue_id[0]) if maybe_number != [] else
None
I get a "NoneType object is unsubscriptable"

http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
projecthosting_upload.py:113: def query_user(self, issue = None)
need a : here

http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
projecthosting_upload.py:118: info = raw_input("This is an invalid entry. 
Please enter either an issue number (just digits, no spaces) or nothing to
create an issue: ")
4-space indent

http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
projecthosting_upload.py:141: issue, problem = self.update_issue(issue_id,
description)
if you really want to avoid uploading anything, then just comment out these
lines, and dump a "print issue_id" above it.

http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
projecthosting_upload.py:163: #upload("rietveld_issue_id", None, "test issue",
"blah")
uncomment these to test.  Feel free to add your own "subject" or "description"
with whatever type of text you want to test for the issue_id finding.

[mike_apollinemike.com, 2011-09-27 09:24:29]

On Sep 27, 2011, at 10:39 AM, percival.music.ca@gmail.com wrote:

> I'll need a github account name from you to enable random pushing to my
> git-cl repo.
> https://github.com/
> 

mikesol

> I'm not going to picky about applying changes to this repo... although
> maybe it's good for me to take a quick peek at whatever you do, given
> some of the problems below.  :)
> 
> 

That's the type of stuff I can scrub if I can test the script - I'll use your
mewes example.

> 
> http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py
> File projecthosting_upload.py (right):
> 
>
http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
> projecthosting_upload.py:18: try :
> 4-space indents please
> 

Ok.

>
http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
> projecthosting_upload.py:28: #PROJECT_NAME = "mewes"
> To test this, comment the "mewes" line and comment out the lilypond
> line.
> 
>
http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
> projecthosting_upload.py:108: maybe_number = [int(x) for x in
> re.findall(r'[0-9]+', text)]
> this finds any number; I'd like to restrict the numbers to "issue" /
> "fix" (with any capitalization), and maybe stuff like (123).
> 

Ok.

> I certainly think we should avoid things like "According to Stone 1994,
> beams should have 3 staff spaces (fix 1234)" picking up 1994.
> 
>
http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
> projecthosting_upload.py:111: return str(issue_id[0]) if maybe_number !=
> [] else None
> I get a "NoneType object is unsubscriptable"
> 

Got it...will change.

>
http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
> projecthosting_upload.py:113: def query_user(self, issue = None)
> need a : here
> 

Will change.

>
http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
> projecthosting_upload.py:118: info = raw_input("This is an invalid
> entry.  Please enter either an issue number (just digits, no spaces) or
> nothing to create an issue: ")
> 4-space indent
> 
>
http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
> projecthosting_upload.py:141: issue, problem =
> self.update_issue(issue_id, description)
> if you really want to avoid uploading anything, then just comment out
> these lines, and dump a "print issue_id" above it.
> 
>
http://codereview.appspot.com/5144045/diff/2001/projecthosting_upload.py#newc...
> projecthosting_upload.py:163: #upload("rietveld_issue_id", None, "test
> issue", "blah")
> uncomment these to test.  Feel free to add your own "subject" or
> "description" with whatever type of text you want to test for the
> issue_id finding.
> 
Ok - thanks!

[Graham Percival, 2011-09-27 09:29:04]

On Tue, Sep 27, 2011 at 11:24:23AM +0200, mike@apollinemike.com wrote:
> On Sep 27, 2011, at 10:39 AM, percival.music.ca@gmail.com wrote:
> 
> > I'll need a github account name from you to enable random pushing to my
> > git-cl repo.
> > https://github.com/
> 
> mikesol

ok, you can push at will.

Same goes for anybody else interested; just give me your username
and I'll add you as a collaborator for git-cl.  As long as your
patches don't break stuff, go ahead and push first and ask
questions later.

Cheers,
- Graham