Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(296)

Issue 5134047: MIDI volume can exceed maximum value (fix 1938) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by janek
Modified:
12 years, 3 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

MIDI volume can exceed maximum value (fix 1938) make Dynamic performer respect midiMinimumVolume and midiMaximumVolume, also with (de)crescendi which aren't terminated by absolute dynamic mark.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M lily/audio-item.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M lily/dynamic-performer.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/audio-item.hh View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
janek
http://code.google.com/p/lilypond/issues/detail?id=1938 fix by Heikki Tauriainen
12 years, 6 months ago (2011-09-26 22:36:46 UTC) #1
pkx166h
passes make and reg tests
12 years, 6 months ago (2011-09-27 21:28:33 UTC) #2
Colin Campbell
Pushed on behalf of James/Heikki as 2bbf0334903db23ad9cb3d3fcbf826cf41d45546
12 years, 5 months ago (2011-10-07 02:29:07 UTC) #3
janek
12 years, 3 months ago (2011-12-25 22:52:48 UTC) #4
On 2011/10/07 02:29:07, Colin Campbell wrote:
> Pushed on behalf of James/Heikki as 2bbf0334903db23ad9cb3d3fcbf826cf41d45546

I close Rietveld issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b