Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(211)

Issue 5133048: godoc: replace explicit escaping with htmltemplate

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by MikeSamuel
Modified:
14 years, 3 months ago
Reviewers:
Visibility:
Public.

Description

godoc: replace explicit escaping with htmltemplate I tested this by running godoc --http=:8081 --html in a fresh client and running the equivalent with port 8080 in a patched client, running the script below and inspecting the result. for path in '/' '/pkg/' '/cmd/' '/doc/go_spec.html' \ '/doc/install.html' '/doc/go_tutorial.html' \ '/doc/effective_go.html' '/doc/go_faq.html' \ '/doc/docs.html' '/error.html<script>alert(42)</script>' \ '/pkg/exp/template/html/' \ '/src/pkg/exp/template/html/content.go?s=238:1880'; do echo $path diff -u <(curl "http://localhost:8081$path" \ | perl -pe 's/\d+\+(. Except as noted)/<rev>+$1/') \ <(curl "http://localhost:8080$path" \ | perl -pe 's/\d+&#43;(. Except as noted)/<rev>+$1/') echo echo done The perl substitution smooths over differences in revision numbers and in the escaping of '+'. The remaining differences are elided comments.

Patch Set 1 #

Patch Set 2 : diff -r 05f0f5fe5d5e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 05f0f5fe5d5e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 215f5a8a5892 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 224c7e1777ed https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -66 lines) Patch
M lib/godoc/codewalk.html View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M lib/godoc/codewalkdir.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/godoc/dirlist.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M lib/godoc/error.html View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/godoc/godoc.html View 1 2 3 5 chunks +10 lines, -10 lines 0 comments Download
M lib/godoc/package.html View 1 2 3 7 chunks +10 lines, -10 lines 0 comments Download
M lib/godoc/search.html View 1 2 3 5 chunks +16 lines, -16 lines 0 comments Download
M src/cmd/godoc/codewalk.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/godoc/godoc.go View 1 15 chunks +25 lines, -16 lines 0 comments Download
M src/cmd/godoc/main.go View 1 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b