Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(48)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
5132046
: Fix leak of mask in draw. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by
bungeman
Modified:
13 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.
Patch Set 1
#
Created:
13 years, 10 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+3 lines, -5 lines
)
Patch
M
src/core/SkDraw.cpp
View
1 chunk
+3 lines, -5 lines
0 comments
Download
Messages
Total messages: 3
Expand All Messages
|
Collapse All Messages
bungeman
13 years, 10 months ago (2011-09-26 18:12:13 UTC)
#1
Sign in
to reply to this message.
reed1
Why do we no longer init fImage to NULL? Won't it be uninitialized now?
13 years, 10 months ago (2011-09-26 18:36:25 UTC)
#2
Why do we no longer init fImage to NULL? Won't it be uninitialized now?
Sign in
to reply to this message.
bungeman
Committed revision 2333.
13 years, 10 months ago (2011-09-26 19:09:51 UTC)
#3
Committed revision 2333.
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 5132046: Fix leak of mask in draw. (Closed)
Created 13 years, 10 months ago by bungeman
Modified 13 years, 10 months ago
Reviewers: reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b