Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3937)

Issue 5131045: Build dependencies for .texi files (issue 1852). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Julien Rioux
Modified:
12 years, 3 months ago
CC:
lilypond-devel_gnu.org, janek
Visibility:
Public.

Description

Build dependencies for .texi files (issue 1852). Write .dep files containing make dependency rules for .texi and .itexi files. They allow to simply type `make' to process the doc after changing an included file and have the manuals updated with the minimum amount of processing. These .dep files are generated by recursively scanning for lines starting with @include in the .texi files, and looking up these included files within the include directories that we pass to texinfo. The same is done for .itexi files. The .dep files are included into the build by stepmake/generic-targets.make. With this we can clean up Documentation/GNUmakefile a bit: - Remove the previous apparently unsuccessfull attempt at tracking dependencies with a wildcard, and - Remove dependencies that are caught automatically: only generated files need an explicit dependency, which weblinks.itexi is an example, thus - Add the explicit dependency for weblinks.itexi.

Patch Set 1 #

Patch Set 2 : Dependencies for .texi files (issue 1852): Take care of recursive includes and include paths. #

Total comments: 10

Patch Set 3 : Add comments. Also, I could remove the shell call. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M Documentation/GNUmakefile View 1 2 3 chunks +5 lines, -12 lines 0 comments Download
M stepmake/stepmake/texinfo-rules.make View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M stepmake/stepmake/texinfo-vars.make View 1 2 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 11
Julien Rioux
Apparently we have to publish this.
12 years, 6 months ago (2011-09-26 21:33:36 UTC) #1
Julien Rioux
Last try.
12 years, 6 months ago (2011-09-27 09:06:36 UTC) #2
Graham Percival (old account)
the email came through without trouble; the problem is the uploading. Wait for Janek to ...
12 years, 6 months ago (2011-09-27 09:12:44 UTC) #3
Julien Rioux
On 2011/09/27 09:12:44, Graham Percival wrote: > the email came through without trouble; the problem ...
12 years, 6 months ago (2011-10-01 23:53:12 UTC) #4
Julien Rioux
This should address the comments posted at http://codereview.appspot.com/5169041/ http://codereview.appspot.com/5131045/diff/5001/Documentation/GNUmakefile File Documentation/GNUmakefile (left): http://codereview.appspot.com/5131045/diff/5001/Documentation/GNUmakefile#oldcode250 Documentation/GNUmakefile:250: $(eval ...
12 years, 6 months ago (2011-10-02 00:05:41 UTC) #5
Graham Percival (old account)
Looks great, although I can't test it until tomorrow. Your rietveld comments are fantastic, but ...
12 years, 6 months ago (2011-10-02 14:43:46 UTC) #6
Graham Percival (old account)
tested and looks great. I'd like to re-iterate the request to move the rietveld comments ...
12 years, 5 months ago (2011-10-04 11:57:19 UTC) #7
Julien Rioux
Sure, when there are no more comments from reviewers I will proceed to modify the ...
12 years, 5 months ago (2011-10-04 13:04:44 UTC) #8
Reinhold
http://codereview.appspot.com/5131045/diff/5001/stepmake/stepmake/texinfo-vars.make File stepmake/stepmake/texinfo-vars.make (right): http://codereview.appspot.com/5131045/diff/5001/stepmake/stepmake/texinfo-vars.make#newcode15 stepmake/stepmake/texinfo-vars.make:15: ) On 2011/10/04 13:04:44, Julien Rioux wrote: > An ...
12 years, 5 months ago (2011-10-04 13:15:12 UTC) #9
Julien Rioux
> AFAIK, texi2* simply include the first file found in the include pathes. So if ...
12 years, 5 months ago (2011-10-04 14:02:13 UTC) #10
Graham Percival (old account)
12 years, 5 months ago (2011-10-05 11:11:02 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b