Issue 5131042: fix override issue, add consts, remove unused var

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5131042: fix override issue, add consts, remove unused var (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by bsalomon

Modified:
13 years, 2 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -8 lines)			Patch
M	gm/base-win/complexclip_gpu.png	View	Binary file		0 comments	Download
M	gm/base-win/hairmodes_gpu.png	View	Binary file		0 comments	Download
M	gpu/src/GrAAHairLinePathRenderer.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	gpu/src/GrAAHairLinePathRenderer.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/src/GrPathRenderer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/src/GrTesselatedPathRenderer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/src/GrTesselatedPathRenderer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

bsalomon

I introduced an override bug on Friday! It would have been caught by SK_OVERRIDE.

13 years, 2 months ago (2011-09-26 15:19:50 UTC) #1

reed1

LGTM **MAN** I wish we got a warning when an override misses by just const

13 years, 2 months ago (2011-09-26 15:58:15 UTC) #2

bsalomon

13 years, 2 months ago (2011-09-28 14:13:05 UTC) #3

On 2011/09/26 15:58:15, reed1 wrote:
> LGTM
> 
> **MAN** I wish we got a warning when an override misses by just const

Closed with 2328