Issue 5121042: lily/bezier.cc: Avoid a floating point compare

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5121042: lily/bezier.cc: Avoid a floating point compare (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by Keith

Modified:
12 years, 7 months ago

Reviewers:
pkx166h, joeneeman

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

lily/bezier.cc: Safer use of floating point (issue 1925)

Patch Set 2 : better handle a corner case #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -43 lines)			Patch
	M	lily/bezier.cc	View	1	1 chunk	+30 lines, -43 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Keith

http://codereview.appspot.com/5121042/diff/1/lily/bezier.cc File lily/bezier.cc (right): http://codereview.appspot.com/5121042/diff/1/lily/bezier.cc#newcode233 lily/bezier.cc:233: sols.push_back (0.0); Better to use 0.999 and 0.001 // ...

12 years, 7 months ago (2011-09-24 18:26:09 UTC) #1

lgtm

Expand All Messages | Collapse All Messages