Issue 5109041: Use GrAAHairlineRenderer for line segments only if FS derivs not avail

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5109041: Use GrAAHairlineRenderer for line segments only if FS derivs not avail (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bsalomon

Modified:
13 years ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -25 lines)			Patch
M	gm/base-win/complexclip_gpu.png	View	Binary file		0 comments	Download
M	gpu/src/GrAAHairLinePathRenderer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/src/GrAAHairLinePathRenderer.cpp	View	2 chunks	+18 lines, -23 lines	2 comments	Download
M	gpu/src/GrPathRendererChain.cpp	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

http://codereview.appspot.com/5109041/diff/1/gpu/src/GrPathRendererChain.cpp File gpu/src/GrPathRendererChain.cpp (left): http://codereview.appspot.com/5109041/diff/1/gpu/src/GrPathRendererChain.cpp#oldcode63 gpu/src/GrPathRendererChain.cpp:63: GrPathRenderer::AddPathRenderers(fOwner, fFlags, this); The "default" was incorrectly the most ...

13 years ago (2011-09-23 14:00:01 UTC) #1

reed1

LGTM http://codereview.appspot.com/5109041/diff/1/gpu/src/GrAAHairLinePathRenderer.cpp File gpu/src/GrAAHairLinePathRenderer.cpp (right): http://codereview.appspot.com/5109041/diff/1/gpu/src/GrAAHairLinePathRenderer.cpp#newcode74 gpu/src/GrAAHairLinePathRenderer.cpp:74: GrIndexBuffer* qIdxBuf = gpu->createIndexBuffer(kQuadIdxSBufize, false); I find the ...

13 years ago (2011-09-23 14:08:53 UTC) #2

bsalomon

13 years ago (2011-09-23 14:20:36 UTC) #3

On 2011/09/23 14:08:53, reed1 wrote:
> LGTM
> 
>
http://codereview.appspot.com/5109041/diff/1/gpu/src/GrAAHairLinePathRenderer...
> File gpu/src/GrAAHairLinePathRenderer.cpp (right):
> 
>
http://codereview.appspot.com/5109041/diff/1/gpu/src/GrAAHairLinePathRenderer...
> gpu/src/GrAAHairLinePathRenderer.cpp:74: GrIndexBuffer* qIdxBuf =
> gpu->createIndexBuffer(kQuadIdxSBufize, false);
> I find the // comment more confusing than helpful.
> 
>
http://codereview.appspot.com/5109041/diff/1/gpu/src/GrAAHairLinePathRenderer...
> gpu/src/GrAAHairLinePathRenderer.cpp:76: if (NULL == qIdxBuf ||
> just use qIdxBuf here, instead of qIdxBuffer.get() ?

Closed (with suggestions) by r2316

Expand All Messages | Collapse All Messages