Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(384)

Issue 5109041: Use GrAAHairlineRenderer for line segments only if FS derivs not avail (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by bsalomon
Modified:
13 years, 1 month ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M gm/base-win/complexclip_gpu.png View Binary file 0 comments Download
M gpu/src/GrAAHairLinePathRenderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/src/GrAAHairLinePathRenderer.cpp View 2 chunks +18 lines, -23 lines 2 comments Download
M gpu/src/GrPathRendererChain.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
bsalomon
http://codereview.appspot.com/5109041/diff/1/gpu/src/GrPathRendererChain.cpp File gpu/src/GrPathRendererChain.cpp (left): http://codereview.appspot.com/5109041/diff/1/gpu/src/GrPathRendererChain.cpp#oldcode63 gpu/src/GrPathRendererChain.cpp:63: GrPathRenderer::AddPathRenderers(fOwner, fFlags, this); The "default" was incorrectly the most ...
13 years, 1 month ago (2011-09-23 14:00:01 UTC) #1
reed1
LGTM http://codereview.appspot.com/5109041/diff/1/gpu/src/GrAAHairLinePathRenderer.cpp File gpu/src/GrAAHairLinePathRenderer.cpp (right): http://codereview.appspot.com/5109041/diff/1/gpu/src/GrAAHairLinePathRenderer.cpp#newcode74 gpu/src/GrAAHairLinePathRenderer.cpp:74: GrIndexBuffer* qIdxBuf = gpu->createIndexBuffer(kQuadIdxSBufize, false); I find the ...
13 years, 1 month ago (2011-09-23 14:08:53 UTC) #2
bsalomon
13 years, 1 month ago (2011-09-23 14:20:36 UTC) #3
On 2011/09/23 14:08:53, reed1 wrote:
> LGTM
> 
>
http://codereview.appspot.com/5109041/diff/1/gpu/src/GrAAHairLinePathRenderer...
> File gpu/src/GrAAHairLinePathRenderer.cpp (right):
> 
>
http://codereview.appspot.com/5109041/diff/1/gpu/src/GrAAHairLinePathRenderer...
> gpu/src/GrAAHairLinePathRenderer.cpp:74: GrIndexBuffer* qIdxBuf =
> gpu->createIndexBuffer(kQuadIdxSBufize, false);
> I find the // comment more confusing than helpful.
> 
>
http://codereview.appspot.com/5109041/diff/1/gpu/src/GrAAHairLinePathRenderer...
> gpu/src/GrAAHairLinePathRenderer.cpp:76: if (NULL == qIdxBuf ||
> just use qIdxBuf here, instead of qIdxBuffer.get() ?

Closed (with suggestions) by r2316
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b