Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(588)

Issue 5098042: Use BindFragDataLocation (rather than indexed variant) for FS color output. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by bsalomon
Modified:
13 years, 3 months ago
Reviewers:
Stephen White, junov1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

r2291 (the GrGLShaderVar change) made shaders on GL 3.0 and higher use declared fragment shader outputs. We were binding them using glBindFragDataLocationIndexed which is only available on GL 3.3 or with GL_ARB_blend_func_extended. With this change we use plain old glBindFragDataLocation for the first color output (the index is implicitly 0 using this function).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M gpu/include/GrGLInterface.h View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/src/GrGLInterface.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/src/GrGLProgram.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/src/mac/GrGLDefaultInterface_mac.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/src/mesa/GrGLDefaultInterface_mesa.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/src/unix/GrGLDefaultInterface_unix.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/src/win/GrGLDefaultInterface_win.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
bsalomon
13 years, 3 months ago (2011-09-21 15:20:54 UTC) #1
Stephen White
On 2011/09/21 15:20:54, bsalomon wrote: LGTM
13 years, 3 months ago (2011-09-21 15:40:21 UTC) #2
junov1
On 2011/09/21 15:40:21, Stephen White wrote: > On 2011/09/21 15:20:54, bsalomon wrote: > > LGTM ...
13 years, 3 months ago (2011-09-21 15:58:11 UTC) #3
bsalomon
13 years, 3 months ago (2011-09-21 16:21:28 UTC) #4
Closed with r2299
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b