Issue 5097044: Cleanup handling of GL versions, fix function names

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5097044: Cleanup handling of GL versions, fix function names (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by bsalomon

Modified:
13 years, 2 months ago

Reviewers:
junov, junov1, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : rebase, fixup linux #

Patch Set 3 : linewrap #

Total comments: 1

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -126 lines)			Patch
M	gpu/include/GrGLInterface.h	View	1	1 chunk	+8 lines, -8 lines	1 comment	Download
M	gpu/src/GrGLInterface.cpp	View	1	8 chunks	+35 lines, -70 lines	0 comments	Download
M	gpu/src/GrGpuGL.h	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	gpu/src/GrGpuGL.cpp	View	1	8 chunks	+15 lines, -12 lines	0 comments	Download
M	gpu/src/GrGpuGLShaders.cpp	View	1 2	2 chunks	+5 lines, -5 lines	0 comments	Download
M	gpu/src/mesa/GrGLDefaultInterface_mesa.cpp	View	1	5 chunks	+12 lines, -12 lines	0 comments	Download
M	gpu/src/unix/GrGLDefaultInterface_unix.cpp	View	1	4 chunks	+9 lines, -9 lines	0 comments	Download
M	gpu/src/win/GrGLDefaultInterface_win.cpp	View	1	4 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

junov1

Just one minor comment. Otherwise LGTM http://codereview.appspot.com/5097044/diff/5001/gpu/include/GrGLInterface.h File gpu/include/GrGLInterface.h (right): http://codereview.appspot.com/5097044/diff/5001/gpu/include/GrGLInterface.h#newcode29 gpu/include/GrGLInterface.h:29: #define GR_GL_VER(major, minor) ...

13 years, 2 months ago (2011-09-22 14:19:20 UTC) #4

reed1

+1 good point. We're really packing two numbers into one int. On 2011/09/22 14:19:20, junov1 ...

13 years, 2 months ago (2011-09-22 14:21:15 UTC) #5

Closed with 2308,9. Changed to uint32_t.

Expand All Messages | Collapse All Messages