Issue 5088049: Put caps in a struct, move up to GrDrawTarget

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5088049: Put caps in a struct, move up to GrDrawTarget (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bsalomon

Modified:
13 years ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+382 lines, -456 lines)			Patch
M	gpu/src/GrAAHairLinePathRenderer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/src/GrBufferAllocPool.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	gpu/src/GrContext.cpp	View	1	8 chunks	+20 lines, -18 lines	0 comments	Download
M	gpu/src/GrDrawTarget.h	View		4 chunks	+36 lines, -1 line	0 comments	Download
M	gpu/src/GrDrawTarget.cpp	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	gpu/src/GrGLIndexBuffer.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	gpu/src/GrGLVertexBuffer.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	gpu/src/GrGpu.h	View		4 chunks	+2 lines, -137 lines	0 comments	Download
M	gpu/src/GrGpu.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	gpu/src/GrGpuGL.h	View	1	4 chunks	+45 lines, -19 lines	0 comments	Download
M	gpu/src/GrGpuGL.cpp	View	1	17 chunks	+232 lines, -248 lines	0 comments	Download
M	gpu/src/GrGpuGLFixed.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	gpu/src/GrGpuGLShaders.cpp	View		4 chunks	+8 lines, -8 lines	0 comments	Download
M	gpu/src/GrInOrderDrawBuffer.cpp	View		4 chunks	+5 lines, -7 lines	0 comments	Download
M	gpu/src/GrPathRendererChain.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 2

bsalomon

Funnest review ever! Having caps in GrGpu but not GrDrawTarget has been a pain and ...

13 years ago (2011-09-22 20:31:10 UTC) #1

Closed with r2314