Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(221)

Issue 5073: Add a ly:line-thickness callback for scheme, returning the line thickness (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 6 months ago by Reinhold
Modified:
14 years, 8 months ago
Reviewers:
hanwenn
Visibility:
Public.

Description

Add a ly:line-thickness callback for scheme, returning the line thickness -) Add a callback ly:line-thickness in staff-symbol-referencer-scheme, which simply gives you a Scheme interface to Staff_symbol_referencer::line_thickness (g) -) Use this to shift inverted flags in the flags-in-scheme test case by the stem-width (the 'thickness grob property of the stem is given in units of the line-thickness!), so the flags really attach to the left edge of the stem

Patch Set 1 #

Patch Set 2 : Add a ly:line-thickness callback for scheme, returning the line thickness #

Patch Set 3 : Work in Han-Wen's comments (rename to ly:staff-symbol-line-thickness, remove check) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M input/regression/flags-in-scheme.ly View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M lily/staff-symbol-referencer-scheme.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M scm/safe-lily.scm View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
Reinhold
15 years, 6 months ago (2008-09-11 20:27:52 UTC) #1
hanwenn
http://codereview.appspot.com/5073/diff/1/3 File lily/staff-symbol-referencer-scheme.cc (left): http://codereview.appspot.com/5073/diff/1/3#oldcode42 Line 42: 1, 0, 0, (SCM grob), It looks as ...
15 years, 6 months ago (2008-09-12 06:43:25 UTC) #2
hanwenn
http://codereview.appspot.com/5073/diff/601/403 File lily/staff-symbol-referencer-scheme.cc (right): http://codereview.appspot.com/5073/diff/601/403#newcode41 Line 41: LY_DEFINE (ly_line_thickness, "ly:line-thickness", can you work staff-symbol in ...
15 years, 6 months ago (2008-09-12 13:09:41 UTC) #3
hanwenn
15 years, 6 months ago (2008-09-21 18:45:11 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b