Issue 5058: Use 'long long' integers in Rational class.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5058: Use 'long long' integers in Rational class. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by Neil Puttock

Modified:
14 years, 9 months ago

Reviewers:
hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Use typedef long long from flower-proto.hh #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -25 lines)			Patch
M	flower/include/flower-proto.hh	View		2 chunks	+2 lines, -1 line	1 comment	Download
M	flower/include/rational.hh	View	1	5 chunks	+9 lines, -7 lines	0 comments	Download
M	flower/include/std-string.hh	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	flower/rational.cc	View	1	8 chunks	+21 lines, -14 lines	0 comments	Download
M	flower/std-string.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	lily/lily-guile.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hanwenn

LGTM . I wonder if we should have a typedef long long, though. Maybe int64 ...

15 years, 7 months ago (2008-09-09 22:18:07 UTC) #1

Neil Puttock

On 2008/09/09 22:18:07, hanwenn wrote: > I wonder if we should have a typedef long ...

15 years, 7 months ago (2008-09-11 16:21:11 UTC) #2

hanwenn

15 years, 7 months ago (2008-09-12 06:42:18 UTC) #3

LGTM

please apply.

http://codereview.appspot.com/5058/diff/11/12
File flower/include/flower-proto.hh (right):

http://codereview.appspot.com/5058/diff/11/12#newcode2
Line 2: fflower-proto.hh -- typenames in flowerlib
ff?

Expand All Messages | Collapse All Messages