Issue 5051043: Add some warning messages in ibustext.c

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5051043: Add some warning messages in ibustext.c (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by Peng

Modified:
12 years, 9 months ago

Reviewers:
Yusuke Sato

Base URL:
git@github.com:/ibus/ibus.git@master

Visibility:
Public.

Description

Add some warning message in ibustext.c BUG=None TEST=Linux desktop

Patch Set 2 : Update #

Total comments: 2

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
	M	src/ibustext.c	View	1	3 chunks	+5 lines, -11 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Yusuke Sato

LGTM with one nit. http://codereview.appspot.com/5051043/diff/2001/src/ibustext.c File src/ibustext.c (right): http://codereview.appspot.com/5051043/diff/2001/src/ibustext.c#newcode166 src/ibustext.c:166: g_return_val_if_reached (NULL); g_return_val_fail (buf != ...

12 years, 9 months ago (2011-09-18 08:02:44 UTC) #2

Peng

12 years, 9 months ago (2011-09-18 14:38:56 UTC) #3

http://codereview.appspot.com/5051043/diff/2001/src/ibustext.c
File src/ibustext.c (right):

http://codereview.appspot.com/5051043/diff/2001/src/ibustext.c#newcode166
src/ibustext.c:166: g_return_val_if_reached (NULL);
On 2011/09/18 08:02:44, Yusuke Sato wrote:
> g_return_val_fail (buf != NULL, NULL); (and remove the if block) would be
> better.

Done.

Expand All Messages | Collapse All Messages