Issue 5050041: Fix a crash and add some warning log message.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5050041: Fix a crash and add some warning log message. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by Peng

Modified:
12 years, 7 months ago

Reviewers:
Yusuke Sato, Daiki Ueno

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

Description

Fix a crash and add some warning log message. BUG=Crash in Chrome OS TEST=Linux desktop

Patch Set 1 #

Total comments: 1

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	src/engine.c	View		2 chunks	+16 lines, -3 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Daiki Ueno

On 2011/09/16 16:52:38, Peng wrote: LGTM. Thanks for tightening up the error handling.

12 years, 7 months ago (2011-09-19 01:00:51 UTC) #2

Yusuke Sato

12 years, 7 months ago (2011-09-19 02:10:17 UTC) #3

LGTM

http://codereview.appspot.com/5050041/diff/1/src/engine.c
File src/engine.c (right):

http://codereview.appspot.com/5050041/diff/1/src/engine.c#newcode822
src/engine.c:822: IBusText *text = ibus_text_new_from_unichar (buf[i]);
when the function returns null?

Expand All Messages | Collapse All Messages