Fix 155: parentheses include accidentals and dots.

Fix 155: parentheses include accidentals and dots.

Make parentheses around noteheads include accidentals and dots.
Make parentheses around rests include dots.

[Bertrand Bordage, 2011-09-17 17:31:15]

Hi Joe,

At last, a fix for that!
But this looks unfinished.  Are you working on a solution that would avoid
having to specify the X-extent?

A fix that calculates the font size of the ParenthesesItem according to the
Y-extent of the parenthesized grobs would also be awesome :)

Bertrand

[joeneeman, 2011-09-18 20:28:04]

On 2011/09/17 17:31:15, Bertrand Bordage wrote:
> Hi Joe,
> 
> At last, a fix for that!
> But this looks unfinished.  Are you working on a solution that would avoid
> having to specify the X-extent?

That isn't actually mentioned in the issue report, but ok :)

> A fix that calculates the font size of the ParenthesesItem according to the
> Y-extent of the parenthesized grobs would also be awesome :)

Yes, there's another bug report for that. I haven't attempted it yet.

Joe

[MikeSol, 2011-09-20 05:19:04]

Hey Joe,

For some reason, the scm files say "Upload in progress."
This may come from a MIME type issue for scm files (upload.py doesn't know that
scm files correspond to Scheme language files).

I forget how to fix this, but I know the fix has been suggested somewhere on the
list.

Cheers,
MS

[joeneeman, 2011-09-20 05:53:49]

Thanks, I've re-uploaded it and it seems to work now.

Joe

On Mon, Sep 19, 2011 at 10:19 PM,  <mtsolo@gmail.com> wrote:
> Hey Joe,
>
> For some reason, the scm files say "Upload in progress."
> This may come from a MIME type issue for scm files (upload.py doesn't
> know that scm files correspond to Scheme language files).
>
> I forget how to fix this, but I know the fix has been suggested
> somewhere on the list.
>
> Cheers,
> MS
>
> http://codereview.appspot.com/5047048/
>

[MikeSol, 2011-09-20 07:21:57]

LGTM.

http://codereview.appspot.com/5047048/diff/8001/scm/output-lib.scm
File scm/output-lib.scm (right):

http://codereview.appspot.com/5047048/diff/8001/scm/output-lib.scm#newcode626
scm/output-lib.scm:626: (foo (display "calculating pure y extent"))
¿Qué es?

http://codereview.appspot.com/5047048/diff/8001/scm/output-lib.scm#newcode639
scm/output-lib.scm:639: (let ((syms (ly:grob-property g 'parenthesis-friends
'()))
80 char maximum when possible - you can list the arguments underneath.

[pkx166h, 2011-09-27 21:22:41]

Passes make but I get some reg test 'crossing fingers' messages 

--snip--


/home/jlowe/lilypond-git/input/regression/tablature-grace-notes.log 	

@@ -2,6 +2,10 @@
 Renaming input to:
`/home/jlowe/lilypond-git/input/regression/tablature-grace-notes.ly'
 Interpreting music... 
 Preprocessing graphical objects...
+programming error: no pure Y common refpoint
+continuing, cross fingers
+programming error: no pure Y common refpoint
+continuing, cross fingers
 Calculating line breaks... 
 Drawing systems... 
 Writing header field `texidoc' to
`/home/jlowe/lilypond-git/build/out/lybook-testdb/3b/lily-8f72236e.texidoc
--snip--

See attached at 

http://code.google.com/p/lilypond/issues/detail?id=155#c19

[Carl, 2011-09-28 01:12:02]

>  Preprocessing graphical objects...
> +programming error: no pure Y common refpoint
> +continuing, cross fingers
> +programming error: no pure Y common refpoint
> +continuing, cross fingers
>  Calculating line breaks... 

Looks to me like friends is not defined for TabNoteHead grobs, and perhaps
should be.

Thanks,

Carl

>  Drawing systems... 
>  Writing header field `texidoc' to
> `/home/jlowe/lilypond-git/build/out/lybook-testdb/3b/lily-8f72236e.texidoc
> --snip--
> 
> See attached at 
> 
> http://code.google.com/p/lilypond/issues/detail?id=155#c19