Issue 5039043: Work on 1890: Fix several compiler warnings on amd64 platform (changing variable types)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5039043: Work on 1890: Fix several compiler warnings on amd64 platform (changing variable types) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Reinhold

Modified:
9 years, 2 months ago

Reviewers:
pkx166h, Graham Percival, Keith

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix almost all warnings in flower/ and many in lily/. Most of the remaining warnings are about vsize -> int casting, where I'll have to find a proper solution (we don't want to cast all appearances of vsize to int explicitly, but rather use vsize wherever possible).

Patch Set 1 : Fix almost all warnings in flower, many in lily/; remaining warnings are mostly vsize -> int casting #

Total comments: 1

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -56 lines)			Patch
M	flower/cpu-timer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	flower/file-cookie.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	flower/getopt-long.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	flower/include/file-cookie.hh	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	flower/include/memory-stream.hh	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	flower/include/polynomial.hh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	flower/include/string-convert.hh	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	flower/memory-stream.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	flower/polynomial.cc	View	3 chunks	+10 lines, -10 lines	1 comment	Download
M	flower/std-string.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	flower/string-convert.cc	View	5 chunks	+14 lines, -6 lines	0 comments	Download
M	lily/include/paper-book.hh	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	lily/paper-book.cc	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	lily/parse-scm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/pfb.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/spring.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lily/volta-repeat-iterator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Graham Percival

according to wikipedia, ssize_t is not part of the ANSI or ISO C standard; it's ...

13 years, 6 months ago (2011-10-31 06:25:19 UTC) #2

Keith

13 years, 6 months ago (2011-11-01 00:37:20 UTC) #3

Looks fine to me.
The type ssize_t is unusual, but it was already in the code before this patch.

http://codereview.appspot.com/5039043/diff/3001/flower/polynomial.cc
File flower/polynomial.cc (right):

http://codereview.appspot.com/5039043/diff/3001/flower/polynomial.cc#newcode332
flower/polynomial.cc:332: Polynomial::degree ()const
This one would be better as a cast to int, because it is an interface function,
and allowing for polynomials of degree greater than 2Billion is just too weird.

Expand All Messages | Collapse All Messages