Simplify specification of default interface

[bsalomon, 2011-09-16 15:41:00]

The setting / getting of the default GL interface became overly complicated to
facilitate two-sided changes. This simplifies things so there is a single
function that returns a default interface and removes the getter and setter.
It's up to the implementation whether it creates a new one for each call or not.

[TomH, 2011-09-16 17:31:46]

LGTM

http://codereview.appspot.com/5036045/diff/4001/gpu/include/GrGLInterface.h
File gpu/include/GrGLInterface.h (right):

http://codereview.appspot.com/5036045/diff/4001/gpu/include/GrGLInterface.h#n...
gpu/include/GrGLInterface.h:53: * to a particular GL context.
GrGLDefaultInterface is called during GrContext
The sentence break above should probably be a paragraph break? Some of the
following is sentence fragments that are hard to follow.

http://codereview.appspot.com/5036045/diff/4001/gpu/src/GrGpuFactory.cpp
File gpu/src/GrGpuFactory.cpp (right):

http://codereview.appspot.com/5036045/diff/4001/gpu/src/GrGpuFactory.cpp#newc...
gpu/src/GrGpuFactory.cpp:33: glInterfaceUnref.reset(glInterface);
I don't understand all the AutoT idioms well enough to see what this is doing.

[bsalomon, 2011-09-16 17:58:36]

http://codereview.appspot.com/5036045/diff/4001/gpu/include/GrGLInterface.h
File gpu/include/GrGLInterface.h (right):

http://codereview.appspot.com/5036045/diff/4001/gpu/include/GrGLInterface.h#n...
gpu/include/GrGLInterface.h:53: * to a particular GL context.
GrGLDefaultInterface is called during GrContext
On 2011/09/16 17:31:47, TomH wrote:
> The sentence break above should probably be a paragraph break? Some of the
> following is sentence fragments that are hard to follow.

I cleaned up the comment.

http://codereview.appspot.com/5036045/diff/4001/gpu/src/GrGpuFactory.cpp
File gpu/src/GrGpuFactory.cpp (right):

http://codereview.appspot.com/5036045/diff/4001/gpu/src/GrGpuFactory.cpp#newc...
gpu/src/GrGpuFactory.cpp:33: glInterfaceUnref.reset(glInterface);
On 2011/09/16 17:31:47, TomH wrote:
> I don't understand all the AutoT idioms well enough to see what this is doing.

SkAutoTUnref just unrefs in its destructor. GrGLDefaultInterface() will either
return a new object or bump a ref on a static. In either case we want to unref
after the GrGpu object is created and takes a ref. I'll add a comment.

[bsalomon, 2011-09-16 20:47:45]

Closed with r2276.