Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(432)

Issue 5036044: Update SkCoInitialize to better match spec. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by bungeman
Modified:
12 years, 9 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

SkAutoCoInitialize isn't as useful of an abstraction as it could be. If COM is already initialized, most users will think things failed. Instead, change things up so that it just says if COM is initialized, since we should never care what the actual threading model is.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M include/utils/win/SkAutoCoInitialize.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ports/SkImageDecoder_WIC.cpp View 2 chunks +8 lines, -4 lines 2 comments Download
M src/utils/win/SkAutoCoInitialize.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3
bungeman
12 years, 9 months ago (2011-09-16 14:49:37 UTC) #1
bsalomon
LGTM http://codereview.appspot.com/5036044/diff/1/src/ports/SkImageDecoder_WIC.cpp File src/ports/SkImageDecoder_WIC.cpp (right): http://codereview.appspot.com/5036044/diff/1/src/ports/SkImageDecoder_WIC.cpp#newcode29 src/ports/SkImageDecoder_WIC.cpp:29: if (!scopedCo.succeeded()) return false; nit: style is to ...
12 years, 9 months ago (2011-09-16 14:52:49 UTC) #2
bungeman
12 years, 9 months ago (2011-09-16 15:37:59 UTC) #3
Committed revision 2274.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b