Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1920)

Issue 5032047: Fix 155. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by joeneeman
Modified:
12 years, 7 months ago
Reviewers:
pkx166h, Graham Percival, reinhold
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix 155. Make parentheses around noteheads include accidentals and dots as well.

Patch Set 1 #

Patch Set 2 : Fix patch description. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
A input/regression/parenthesize-notes-accidentals.ly View 1 chunk +15 lines, -0 lines 0 comments Download
M lily/grob.cc View 1 chunk +1 line, -0 lines 0 comments Download
scm/define-grob-properties.scm View 1 chunk +3 lines, -0 lines 0 comments Download
scm/define-grobs.scm View 2 chunks +2 lines, -0 lines 0 comments Download
scm/output-lib.scm View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 3
pkx166h
Passes make and reg tests
12 years, 7 months ago (2011-09-17 12:30:23 UTC) #1
reinhold_kainhofer.com
Am Saturday, 17. September 2011, 14:30:23 schrieb pkx166h@gmail.com: > Passes make and reg tests > ...
12 years, 7 months ago (2011-09-17 12:36:11 UTC) #2
Graham Percival
12 years, 7 months ago (2011-09-17 16:40:07 UTC) #3
On Sat, Sep 17, 2011 at 02:36:04PM +0200, Reinhold Kainhofer wrote:
> It would be really nice to have a better summary than "Fix 155". This does not

> tell me ANYTHING about what this is all about,

Agreed.  James, please take another look at:
http://lilypond.org/doc/v2.15/Documentation/contributor/patch-handling

No patch should get "patch-review" unless it has a descriptive
subject line.  By all means test to see if a patch has any regtest
changes, but if the subject is not good, make a note of that and
explain that you cannot mark it -review for that reason.

Cheers,
- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b