Am Saturday, 17. September 2011, 14:30:23 schrieb pkx166h@gmail.com: > Passes make and reg tests > ...
12 years, 7 months ago
(2011-09-17 12:36:11 UTC)
#2
Am Saturday, 17. September 2011, 14:30:23 schrieb pkx166h@gmail.com:
> Passes make and reg tests
>
> http://codereview.appspot.com/5032047/
It would be really nice to have a better summary than "Fix 155". This does not
tell me ANYTHING about what this is all about, so I'll have to click on the
link to find out what this patch is for (and either remember this, or have to
visit the rietveld page again when I can't remember what all the lilypond bug
numbers are about).
Or of course I simply ignore that mail, which is usually what I do.
So, please add a short summary to the patch summary! This is also preferred
for the actual git commit, since having a patch summary of "Fix 155" is just
as un-helpful in the the git history as it is here.
Cheers,
Reinhold
--
------------------------------------------------------------------
Reinhold Kainhofer, reinhold@kainhofer.com, http://reinhold.kainhofer.com/
* Financial & Actuarial Math., Vienna Univ. of Technology, Austria
* http://www.fam.tuwien.ac.at/, DVR: 0005886
* LilyPond, Music typesetting, http://www.lilypond.org
On Sat, Sep 17, 2011 at 02:36:04PM +0200, Reinhold Kainhofer wrote: > It would be ...
12 years, 7 months ago
(2011-09-17 16:40:07 UTC)
#3
On Sat, Sep 17, 2011 at 02:36:04PM +0200, Reinhold Kainhofer wrote:
> It would be really nice to have a better summary than "Fix 155". This does not
> tell me ANYTHING about what this is all about,
Agreed. James, please take another look at:
http://lilypond.org/doc/v2.15/Documentation/contributor/patch-handling
No patch should get "patch-review" unless it has a descriptive
subject line. By all means test to see if a patch has any regtest
changes, but if the subject is not good, make a note of that and
explain that you cannot mark it -review for that reason.
Cheers,
- Graham
Issue 5032047: Fix 155.
(Closed)
Created 12 years, 7 months ago by joeneeman
Modified 12 years, 7 months ago
Reviewers: pkx166h, reinhold_kainhofer.com, Graham Percival
Base URL:
Comments: 0