http://codereview.appspot.com/5032043/diff/1/src/wifi/model/wifi-mode.h File src/wifi/model/wifi-mode.h (right): http://codereview.appspot.com/5032043/diff/1/src/wifi/model/wifi-mode.h#newcode207 src/wifi/model/wifi-mode.h:207: uint64_t dataRate, It looks good to me. My only ...
14 years, 8 months ago
(2011-09-20 20:52:40 UTC)
#1
14 years, 8 months ago
(2011-09-20 21:56:26 UTC)
#2
On 2011/09/20 20:52:40, Ruben Merz wrote:
> http://codereview.appspot.com/5032043/diff/1/src/wifi/model/wifi-mode.h
> File src/wifi/model/wifi-mode.h (right):
>
>
http://codereview.appspot.com/5032043/diff/1/src/wifi/model/wifi-mode.h#newco...
> src/wifi/model/wifi-mode.h:207: uint64_t dataRate,
> It looks good to me. My only question is whether we want to commit the updated
> bindings along with this.
>
> @Tom: any opinion on that?
>
> Ruben
There are some unrelated bindings updates in the above patch set that have
already been committed to ns-3-dev, but yes, I would apply the revised bindings
for this specific change, either with this changeset or with a separate
changeset.
On 2011/09/20 21:56:26, Tom Henderson wrote: > On 2011/09/20 20:52:40, Ruben Merz wrote: > > ...
14 years, 8 months ago
(2011-09-21 02:14:20 UTC)
#3
On 2011/09/20 21:56:26, Tom Henderson wrote:
> On 2011/09/20 20:52:40, Ruben Merz wrote:
> > http://codereview.appspot.com/5032043/diff/1/src/wifi/model/wifi-mode.h
> > File src/wifi/model/wifi-mode.h (right):
> >
> >
>
http://codereview.appspot.com/5032043/diff/1/src/wifi/model/wifi-mode.h#newco...
> > src/wifi/model/wifi-mode.h:207: uint64_t dataRate,
> > It looks good to me. My only question is whether we want to commit the
updated
> > bindings along with this.
> >
> > @Tom: any opinion on that?
> >
> > Ruben
>
> There are some unrelated bindings updates in the above patch set that have
> already been committed to ns-3-dev, but yes, I would apply the revised
bindings
> for this specific change, either with this changeset or with a separate
> changeset.
So I'm clear: it sounds like I shouldn't bother sending patches for updated
bindings?
Committed. I'm having a few issues with my pybindgen setup so I've been unable to ...
14 years, 8 months ago
(2011-09-22 18:54:17 UTC)
#4
Committed. I'm having a few issues with my pybindgen setup so I've been unable
to rescan them for. If someone wants to do it, just go ahead.
@Daniel: I'm happily waiting to see the rest of your code. Let us know if you
have any question.
Issue 5032043: Preparation for IEEE 802.11ad support
Created 14 years, 9 months ago by dhalperi
Modified 14 years, 8 months ago
Reviewers: Ruben Merz, Tom Henderson
Base URL:
Comments: 1