Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(197)

Issue 5032043: Preparation for IEEE 802.11ad support

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by dhalperi
Modified:
14 years, 8 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M src/energy/bindings/modulegen__gcc_ILP32.py View 4 chunks +7 lines, -7 lines 0 comments Download
M src/energy/bindings/modulegen__gcc_LP64.py View 4 chunks +7 lines, -7 lines 0 comments Download
M src/mesh/bindings/modulegen__gcc_ILP32.py View 4 chunks +7 lines, -7 lines 0 comments Download
M src/mesh/bindings/modulegen__gcc_LP64.py View 4 chunks +7 lines, -7 lines 0 comments Download
M src/wifi/bindings/modulegen__gcc_ILP32.py View 3 chunks +6 lines, -6 lines 0 comments Download
M src/wifi/bindings/modulegen__gcc_LP64.py View 3 chunks +6 lines, -6 lines 0 comments Download
M src/wifi/model/wifi-mode.h View 3 chunks +5 lines, -5 lines 1 comment Download
M src/wifi/model/wifi-mode.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Ruben Merz
http://codereview.appspot.com/5032043/diff/1/src/wifi/model/wifi-mode.h File src/wifi/model/wifi-mode.h (right): http://codereview.appspot.com/5032043/diff/1/src/wifi/model/wifi-mode.h#newcode207 src/wifi/model/wifi-mode.h:207: uint64_t dataRate, It looks good to me. My only ...
14 years, 8 months ago (2011-09-20 20:52:40 UTC) #1
Tom Henderson
On 2011/09/20 20:52:40, Ruben Merz wrote: > http://codereview.appspot.com/5032043/diff/1/src/wifi/model/wifi-mode.h > File src/wifi/model/wifi-mode.h (right): > > http://codereview.appspot.com/5032043/diff/1/src/wifi/model/wifi-mode.h#newcode207 ...
14 years, 8 months ago (2011-09-20 21:56:26 UTC) #2
dhalperi
On 2011/09/20 21:56:26, Tom Henderson wrote: > On 2011/09/20 20:52:40, Ruben Merz wrote: > > ...
14 years, 8 months ago (2011-09-21 02:14:20 UTC) #3
Ruben Merz
14 years, 8 months ago (2011-09-22 18:54:17 UTC) #4
Committed. I'm having a few issues with my pybindgen setup so I've been unable
to rescan them for. If someone wants to do it, just go ahead.

@Daniel: I'm happily waiting to see the rest of your code. Let us know if you
have any question.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b