Issue 5031048: Switch from key to userIp for discovery requests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5031048: Switch from key to userIp for discovery requests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by jcgregorio_google

Modified:
12 years, 11 months ago

Reviewers:
ade

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -11 lines)			Patch
M	apiclient/discovery.py	View	1 chunk	+4 lines, -1 line	2 comments	Download
M	samples/api-python-client-doc/main.py	View	3 chunks	+18 lines, -7 lines	0 comments	Download
M	tests/test_discovery.py	View	3 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ade

LGTM http://codereview.appspot.com/5031048/diff/1/apiclient/discovery.py File apiclient/discovery.py (right): http://codereview.appspot.com/5031048/diff/1/apiclient/discovery.py#newcode159 apiclient/discovery.py:159: if 'REMOTE_ADDR' in os.environ: Can you add a ...

12 years, 11 months ago (2011-09-16 19:37:45 UTC) #2

jcgregorio_google

12 years, 11 months ago (2011-09-16 20:11:13 UTC) #3

http://codereview.appspot.com/5031048/diff/1/apiclient/discovery.py
File apiclient/discovery.py (right):

http://codereview.appspot.com/5031048/diff/1/apiclient/discovery.py#newcode159
apiclient/discovery.py:159: if 'REMOTE_ADDR' in os.environ:
On 2011/09/16 19:37:46, ade wrote:
> Can you add a comment explaining which environments (servers) this variable
will
> exist in .

Done.

Expand All Messages | Collapse All Messages