Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 50290045: Issue 3797: Music_wrapper_iterator does not follow original context setting of child (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by dak
Modified:
10 years, 2 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3797: Music_wrapper_iterator does not follow original context setting of child We try doing this with a descend_to_child (child_iter->get_outlet ()) after initializing the child iterator. It's not clear that this will work in all cases, but at least it addresses the reported issue where: \score { << { { a4 a b b } a a b b } { \absolute { a4 a b b } a a b b } >> } splits off a new Staff after \absolute { a4 a b b }.

Patch Set 1 #

Patch Set 2 : Use virtual set_context/get_handle to refrain from duplicate contexts #

Patch Set 3 : Make a few safety related fixes, in particular to avoid early gc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M lily/include/music-iterator.hh View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lily/include/music-wrapper-iterator.hh View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lily/music-iterator.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M lily/music-wrapper-iterator.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2
dak
Use virtual set_context/get_handle to refrain from duplicate contexts
10 years, 3 months ago (2014-01-11 19:11:19 UTC) #1
dak
10 years, 3 months ago (2014-01-11 22:35:50 UTC) #2
Make a few safety related fixes, in particular to avoid early gc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b