Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1347)

Issue 5022042: remove nonexistent files from gyps and make AdditionalOptions a list rather than str (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by bsalomon
Modified:
13 years, 1 month ago
Reviewers:
bungeman, seanpaul
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M gyp/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/core.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3
bsalomon
13 years, 1 month ago (2011-09-13 20:46:26 UTC) #1
seanpaul
LGTM
13 years, 1 month ago (2011-09-13 20:54:45 UTC) #2
bsalomon
13 years, 1 month ago (2011-09-13 21:14:03 UTC) #3
Closed with r2262. (Ben can yell at me after the fact if he doesn't like it :) )
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b