Issue 50130044: Allow scheme functions and identifiers to function as output definitions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 50130044: Allow scheme functions and identifiers to function as output definitions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by dak

Modified:
10 years, 2 months ago

Reviewers:
carl.d.sorensen, Carl

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Allow scheme functions and identifiers to function as output definitions

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -20 lines)			Patch
	M	lily/parser.yy	View	1	5 chunks	+49 lines, -20 lines	0 comments	Download

Total messages: 2

Carl

10 years, 3 months ago (2014-01-10 12:37:20 UTC) #2

LGTM, although I'm not sure I could identify weakness in such a patch. The idea
is good. I like the structure and the comments.