Issue 5012046: Workaround crash in cmd buffer validation code when GL shaders/programs fail

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5012046: Workaround crash in cmd buffer validation code when GL shaders/programs fail (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by bsalomon

Modified:
13 years, 3 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	gpu/src/GrGLProgram.cpp	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Total messages: 4

bsalomon

The chrome cmd buffer code attempts to validate that the length param to the glGet*InfoLog ...

13 years, 3 months ago (2011-09-14 14:04:54 UTC) #1

TomH

LGTM. Can you file a low-priority upstream bug to get them to fix their generator? ...

13 years, 3 months ago (2011-09-14 14:18:31 UTC) #2

bsalomon

On 2011/09/14 14:18:31, TomH wrote: > LGTM. > > Can you file a low-priority upstream ...

13 years, 3 months ago (2011-09-14 14:39:20 UTC) #3

Closed with r2267