Issue 5011047: Closure compiler optimizes away html_sanitize too aggressively

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5011047: Closure compiler optimizes away html_sanitize too aggressively (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by Jasvir

Modified:
14 years, 8 months ago

Reviewers:
MikeSamuel

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Changed html_sanitize to be exported using closure friendly convention @4626

Patch Set 1 #

Patch Set 2 : Closure compiler optimizes away html_sanitize too aggressively #

Patch Set 3 : Closure compiler optimizes away html_sanitize too aggressively #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/com/google/caja/plugin/html-sanitizer.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

MikeSamuel

LGTM 2011/9/14 <jasvir@gmail.com>: > Reviewers: MikeSamuel, > > Description: > Changed html_sanitize to be exported ...

14 years, 9 months ago (2011-09-14 20:45:33 UTC) #2

MikeSamuel

14 years, 9 months ago (2011-09-14 20:49:55 UTC) #3

LGTM with html -> window['html'] as well.

2011/9/14 Mike Samuel <mikesamuel@gmail.com>:
> LGTM
>
> 2011/9/14  <jasvir@gmail.com>:
>> Reviewers: MikeSamuel,
>>
>> Description:
>> Changed html_sanitize to be exported using closure friendly convention
>>
>> Please review this at http://codereview.appspot.com/5011047/
>>
>> Affected files:
>>  M     src/com/google/caja/plugin/html-sanitizer.js
>>
>>
>> Index: src/com/google/caja/plugin/html-sanitizer.js
>> ===================================================================
>> --- src/com/google/caja/plugin/html-sanitizer.js        (revision 4623)
>> +++ src/com/google/caja/plugin/html-sanitizer.js        (working copy)
>> @@ -562,4 +562,4 @@
>>   };
>>  })(html4);
>>
>> -var html_sanitize = html.sanitize;
>> +window['html_sanitize'] = html.sanitize;
>>
>>
>>
>

Expand All Messages | Collapse All Messages