On 2011/09/12 18:11:43, bsalomon wrote: > Looks like the raster code could use some perspective ...
13 years, 3 months ago
(2011-09-13 13:54:51 UTC)
#2
On 2011/09/12 18:11:43, bsalomon wrote:
> Looks like the raster code could use some perspective TLC, too. There's a
weird
> banding of a gradient radius.
ping
Someday lets formalize some silent-error callback trick, so we can send the client (if they ...
13 years, 3 months ago
(2011-09-13 14:05:04 UTC)
#3
Someday lets formalize some silent-error callback trick, so we can send the
client (if they want them) errors and warnings like "can't invert matrix"
With lazy nit: LGTM
http://codereview.appspot.com/4994048/diff/8001/gpu/src/GrContext.cpp
File gpu/src/GrContext.cpp (right):
http://codereview.appspot.com/4994048/diff/8001/gpu/src/GrContext.cpp#newcode620
gpu/src/GrContext.cpp:620: if (p != &tmpPaint) {
there exists a slightly fast way to do this lazy paint pattern.
SkTLazy<SkPaint> tmpPaint; // we do no work at all at this stage
if (...) {
p = tmpPaint.set(paint); now p points to tmpPaint, initialized by paint
}
Issue 4994048: more persp fixes and gm
(Closed)
Created 13 years, 3 months ago by bsalomon
Modified 13 years, 3 months ago
Reviewers: reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 1