Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3416)

Issue 4991049: parser.yy et al: Turn \transpose into a music function, make other music functions use ly:pitch? (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by dak
Modified:
12 years, 7 months ago
Reviewers:
pkx166h, Reinhold
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

parser.yy et al: Turn \transpose into a music function. This removes \transpose from its special treatment in the parser.

Patch Set 1 #

Patch Set 2 : Make a number of music functions more straightforward by using ly:pitch? arguments. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -57 lines) Patch
M lily/lily-lexer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M lily/parser.yy View 2 chunks +0 lines, -7 lines 0 comments Download
M ly/music-functions-init.ly View 1 8 chunks +29 lines, -30 lines 2 comments Download
M scm/ly-syntax-constructors.scm View 1 chunk +0 lines, -4 lines 0 comments Download
M scm/modal-transforms.scm View 1 2 chunks +6 lines, -15 lines 0 comments Download

Messages

Total messages: 3
Reinhold
LGTM http://codereview.appspot.com/4991049/diff/2001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/4991049/diff/2001/ly/music-functions-init.ly#newcode852 ly/music-functions-init.ly:852: pitch))) indent (or better, write the whole lambda ...
12 years, 7 months ago (2011-09-09 14:53:31 UTC) #1
pkx166h
passes make and reg tests
12 years, 7 months ago (2011-09-10 10:10:13 UTC) #2
dak
12 years, 7 months ago (2011-09-11 12:50:46 UTC) #3
Made the requested spacing changes and pushed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b