Issue 4977043: Fix GPU backend when clipstack doesn't begin with intersect

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4977043: Fix GPU backend when clipstack doesn't begin with intersect (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by bsalomon

Modified:
13 years, 3 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -26 lines)			Patch
M	gpu/include/GrClip.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	gpu/src/GrClip.cpp	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	gpu/src/GrGpu.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	gpu/src/GrGpu.cpp	View	1	4 chunks	+89 lines, -13 lines	0 comments	Download
M	gpu/src/GrGpuGL.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/src/GrGpuGL.cpp	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	gpu/src/GrGpuGLShaders.cpp	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Total messages: 3

bsalomon

There were a bunch of places in the Gpu code where it assumed that the ...

13 years, 3 months ago (2011-08-29 15:05:44 UTC) #1

reed1

GLShaders change seems spurious... but I like spurious LGTM

13 years, 3 months ago (2011-08-29 15:10:45 UTC) #2

bsalomon

13 years, 3 months ago (2011-08-29 15:19:47 UTC) #3

Hmm.. must of been a line endings change in that file, reverted it and submitted
the rest in r2183.