Issue 4975063: [gpu] Remove getMaxStretch for perspective, use mapRadius for perspective path subdiv tol, add test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4975063: [gpu] Remove getMaxStretch for perspective, use mapRadius for perspective path subdiv tol, add test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bsalomon

Modified:
13 years ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 3 : cleanup #

Total comments: 1

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -73 lines)			Patch
M	gpu/src/GrDefaultPathRenderer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/src/GrPathUtils.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	gpu/src/GrPathUtils.cpp	View		1 chunk	+11 lines, -4 lines	0 comments	Download
M	gpu/src/GrTesselatedPathRenderer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkMatrix.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/core/SkMatrix.cpp	View	1	1 chunk	+33 lines, -62 lines	1 comment	Download
M	tests/MatrixTest.cpp	View	1 2	3 chunks	+91 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

LGTM http://codereview.appspot.com/4975063/diff/2002/src/core/SkMatrix.cpp File src/core/SkMatrix.cpp (right): http://codereview.appspot.com/4975063/diff/2002/src/core/SkMatrix.cpp#newcode1708 src/core/SkMatrix.cpp:1708: SkScalar apluscdiv2 = (a + c) / 2; ...

13 years ago (2011-09-09 18:33:05 UTC) #2

Closed (with SkScalarHalf) at r2246

Expand All Messages | Collapse All Messages