T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2

T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2

If possible, use (ly:format) for simple formatting strings to gain performance.

[pkx166h, 2011-09-11 07:09:04]

Passes make. There is one reg test that shows up that I don't understand the
significance of but it looks ok. Attached in 
http://code.google.com/p/lilypond/issues/detail?id=1780#c14

[Ian Hulin (gmail), 2011-09-18 22:40:36]

New patch-set uploaded for review.

Cheers
Ian

[Bertrand Bordage, 2011-09-18 22:57:39]

Hi Ian,

I have some comments. The rest of the patch LGTM.

Regards,
Bertrand

http://codereview.appspot.com/4974078/diff/3001/scm/document-identifiers.scm
File scm/document-identifiers.scm (right):

http://codereview.appspot.com/4974078/diff/3001/scm/document-identifiers.scm#...
scm/document-identifiers.scm:31: 
Why a new line?

http://codereview.appspot.com/4974078/diff/3001/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/4974078/diff/3001/scm/lily.scm#newcode353
scm/lily.scm:353: (ly:format
Err...
Why is this required?

Be careful with the indentation: there shouldn't be tabulators.

http://codereview.appspot.com/4974078/diff/3001/scripts/musicxml2ly.py
File scripts/musicxml2ly.py (right):

http://codereview.appspot.com/4974078/diff/3001/scripts/musicxml2ly.py#newcode71
scripts/musicxml2ly.py:71: (ly:format #f "~a:~a" den num)))
#f?

[Ian Hulin (gmail), 2011-09-19 22:44:13]

http://codereview.appspot.com/4974078/diff/3001/scm/document-identifiers.scm
File scm/document-identifiers.scm (right):

http://codereview.appspot.com/4974078/diff/3001/scm/document-identifiers.scm#...
scm/document-identifiers.scm:31: 
On 2011/09/18 22:57:39, Bertrand Bordage wrote:
> Why a new line?

Done.

http://codereview.appspot.com/4974078/diff/3001/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/4974078/diff/3001/scm/lily.scm#newcode353
scm/lily.scm:353: (ly:format
On 2011/09/18 22:57:39, Bertrand Bordage wrote:
> Err...
> Why is this required?
> 
> Be careful with the indentation: there shouldn't be tabulators.
ly:format call removed, tabs converted to spaces.

[Ian Hulin (gmail), 2011-09-19 22:50:54]

New patch-set uploaded.

Ian

[Bertrand Bordage, 2011-09-20 10:49:28]

Thanks for applying these!

Sorry to bother you again with indentation, but you don't have to replace spaces
with tabulators in scripts/musicxml2ly.ly .

We decided that the rule for Python is 4 spaces per indentation level.
For more infos, see:
http://lilypond.org/~graham/gop/gop_1.html#GOP-1-_002d-python-formatting

Thanks,
Bertrand

[Ian Hulin (gmail), 2011-09-20 14:15:53]

On 2011/09/20 10:49:28, Bertrand Bordage wrote:
> Thanks for applying these!
> 
> Sorry to bother you again with indentation, but you don't have to replace
spaces
"don't have to" == "don't need to", I assume you mean "you shouldn't" 
> with tabulators in scripts/musicxml2ly.ly .
> 
> We decided that the rule for Python is 4 spaces per indentation level.
> For more infos, see:
> http://lilypond.org/%7Egraham/gop/gop_1.html#GOP-1-_002d-python-formatting
> 
> Thanks,
> Bertrand

New patch-set uploaded with tabs in musicxml2ly.py converted to spaces.

Ian

[Bertrand Bordage, 2011-09-20 14:22:59]

LGTM.

On 2011/09/20 14:15:53, Ian Hulin (gmail) wrote:
> "don't have to" == "don't need to", I assume you mean "you shouldn't" 
> > with tabulators in scripts/musicxml2ly.ly .

Yes, this was a subtle "DON'T DO IT!" :)

[pkx166h, 2011-09-24 19:41:22]

This patch no longer applies to current tree (as of 24th Sept)