Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2354)

Issue 4974071: Fix extension behavior in shader validation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by zmo
Modified:
12 years, 8 months ago
Reviewers:
kbr1, kbr
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix extension behavior in shader validation. If an extension is not specified, it is disabled by default, thus a shader should fail compiling if features from that extension are used. ANGLEBUG=204 TEST=webgl conformance/extensions/oes-standard-derivatives.html Committed: http://code.google.com/p/angleproject/source/detail?r=745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M samples/translator/translator.cpp View 3 chunks +14 lines, -3 lines 0 comments Download
M src/common/version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ParseHelper.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
zmo
Tested manually with the shader in the conformance test. Please review.
12 years, 8 months ago (2011-09-09 01:25:23 UTC) #1
kbr1
12 years, 8 months ago (2011-09-09 01:36:34 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b