Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 4974066: Update to #179: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by erg
Modified:
13 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
erg
Base URL:
http://google-styleguide.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Update to #179: - Suggest "const_cast" when encountering "(char*)". - Warn on template arguments to make_pair(). - Require <utility> if pair<> is seen now that <map> doesn't include it. - Warn on lack of "explicit" keyword on single argument inline constructors. - Better check for hanging ')' when closing function calls. - Don't warn on: 'int v[1][3] = {{1, 2, 3}};' - Allow function calls as the first argument to printf(). Committed: http://code.google.com/p/google-styleguide/source/detail?r=74

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -226 lines) Patch
M cpplint/cpplint.py View 36 chunks +250 lines, -63 lines 0 comments Download
M cpplint/cpplint_unittest.py View 23 chunks +320 lines, -163 lines 0 comments Download

Messages

Total messages: 2
Elliot Glaysher
Here's the rest of it.
13 years, 2 months ago (2011-09-07 23:33:49 UTC) #1
Mark Mentovai
13 years, 2 months ago (2011-09-08 00:09:51 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b