Issue 4974048: new complex clip gm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4974048: new complex clip gm (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by bsalomon

Modified:
13 years, 3 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : remove pdf output #

Patch Set 4 : actually remove pdf fil #

Patch Set 6 : use set to init rects #

Patch Set 7 : move init code to cons #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -3 lines)			Patch
A	gm/base-win/complexclip2_4444.png	View		Binary file		0 comments	Download
A	gm/base-win/complexclip2_565.png	View		Binary file		0 comments	Download
A	gm/base-win/complexclip2_8888.png	View		Binary file		0 comments	Download
A	gm/base-win/complexclip2_gpu.png	View		Binary file		0 comments	Download
A	gm/complexclip2.cpp	View	1 2 3 4 5 6	1 chunk	+134 lines, -0 lines	0 comments	Download
M	gyp/gm.gyp	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

http://codereview.appspot.com/4974048/diff/4002/gm/complexclip2.cpp File gm/complexclip2.cpp (right): http://codereview.appspot.com/4974048/diff/4002/gm/complexclip2.cpp#newcode35 gm/complexclip2.cpp:35: fRects[0].fLeft = xB; for readability, might use fRects[0].set(xB, yB, ...

13 years, 3 months ago (2011-08-29 17:23:53 UTC) #2

bsalomon

13 years, 3 months ago (2011-08-29 17:34:00 UTC) #3

Closed with r2184-6

Expand All Messages | Collapse All Messages