Moving analysis to separate file

[supertri, 2011-09-07 15:51:45]

http://codereview.appspot.com/4973067/diff/1/include/clang/Analysis/Analyses/...
File include/clang/Analysis/Analyses/ThreadSafety.h (right):

http://codereview.appspot.com/4973067/diff/1/include/clang/Analysis/Analyses/...
include/clang/Analysis/Analyses/ThreadSafety.h:28:
//===----------------------------------------------------------------------===//
Will delete this banner comment, and the extra spaces above it.

http://codereview.appspot.com/4973067/diff/1/include/clang/Analysis/Analyses/...
include/clang/Analysis/Analyses/ThreadSafety.h:35: enum VariableAccessKind {
This needs a new name. Basically, this enum is for things which are protected by
locks. Maybe the enum could be "ProtectedOperationKind" with
VariableDereference, VariableAccess, and FunctionCall as options. Thoughts?

http://codereview.appspot.com/4973067/diff/1/lib/Analysis/ThreadSafety.cpp
File lib/Analysis/ThreadSafety.cpp (right):

http://codereview.appspot.com/4973067/diff/1/lib/Analysis/ThreadSafety.cpp#ne...
lib/Analysis/ThreadSafety.cpp:355: //  switch (AK) {
Whoops! I will delete this accidentally left in comment. 

Note that this method was refactored to use the new getLockKindFromAccessKind
and locksetContainsAtLeast methods, and the new Enum (in place of DiagIDs, which
have been removed from this file).

http://codereview.appspot.com/4973067/diff/1/lib/Analysis/ThreadSafety.cpp#ne...
lib/Analysis/ThreadSafety.cpp:544: warnIfMutexNotHeld(D, Exp, AK_Written, Mutex,
VAK_FunctionCall);
I will see if I can move the construction of the Mutex object into
warnIfMutexNotHeld.

http://codereview.appspot.com/4973067/diff/1/lib/Analysis/ThreadSafety.cpp#ne...
lib/Analysis/ThreadSafety.cpp:752: LocksetFactory);
Over 80 characters.

http://codereview.appspot.com/4973067/diff/1/lib/Sema/AnalysisBasedWarnings.cpp
File lib/Sema/AnalysisBasedWarnings.cpp (right):

http://codereview.appspot.com/4973067/diff/1/lib/Sema/AnalysisBasedWarnings.c...
lib/Sema/AnalysisBasedWarnings.cpp:39: #include "llvm/ADT/PostOrderIterator.h"
I need to delete a couple include statements.

http://codereview.appspot.com/4973067/diff/1/lib/Sema/AnalysisBasedWarnings.c...
lib/Sema/AnalysisBasedWarnings.cpp:878: Reporter.emitDiagnostics();
Right now I batch up all warnings and output sorted by source location since I
need to do that anyway for a subset of the warnings. I could have some warnings
output as they appear, and some at the end sorted by source location, but it
seems a bit cleaner to have them all output together. Thoughts on this?