Issue 4969076: parser.yy et al: turn \partial and \skip into music functions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4969076: parser.yy et al: turn \partial and \skip into music functions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by dak

Modified:
12 years, 7 months ago

Reviewers:
Bertrand Bordage, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

parser.yy et al: turn \partial and \skip into music functions.

Patch Set 1 #

Total comments: 2

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -27 lines)			Patch
M	lily/lily-lexer.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	lily/parser.yy	View	4 chunks	+0 lines, -9 lines	0 comments	Download
M	ly/music-functions-init.ly	View	2 chunks	+18 lines, -0 lines	2 comments	Download
M	scm/ly-syntax-constructors.scm	View	2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Neil Puttock

LGTM. http://codereview.appspot.com/4969076/diff/1/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/4969076/diff/1/ly/music-functions-init.ly#newcode794 ly/music-functions-init.ly:794: "Make a partial measure." (_i "Make a partial ...

12 years, 7 months ago (2011-09-12 10:59:06 UTC) #1

Bertrand Bordage

LGTM. Is there any way to also move \time, \key, \repeat and \alternative from the ...

12 years, 7 months ago (2011-09-12 16:53:56 UTC) #2

dak

bordage.bertrand@gmail.com writes: > LGTM. > Is there any way to also move \time, \key, \repeat ...

12 years, 7 months ago (2011-09-12 17:30:36 UTC) #3

Pushed as 12449405eb89bb45d49d3dd3a37bdfcebda3ceaa.

Expand All Messages | Collapse All Messages