Issue 4968066: Refactor setup.c.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4968066: Refactor setup.c. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by Daiki Ueno

Modified:
12 years, 7 months ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

Description

Refactor setup.c. Previously, each config item was saved when corresponding widget state was changed. With this change, changes won't be saved until a user close the setup dialog. BUG=none TEST=manual

Patch Set 1 #

Total comments: 1

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+362 lines, -308 lines)			Patch
	M	src/ibus-m17n-preferences.ui	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/setup.c	View		9 chunks	+360 lines, -307 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Peng

12 years, 7 months ago (2011-09-06 15:22:47 UTC) #2

LGTM. Thanks.

https://codereview.appspot.com/4968066/diff/1/src/setup.c
File src/setup.c (right):

https://codereview.appspot.com/4968066/diff/1/src/setup.c#newcode386
src/setup.c:386: } else
Add {}

Expand All Messages | Collapse All Messages