Issue 4967061: Add 'K' to SampleApp to trigger animated perspective rendering

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4967061: Add 'K' to SampleApp to trigger animated perspective rendering (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by bsalomon

Modified:
13 years, 3 months ago

Reviewers:
bungeman, reed1, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -2 lines)			Patch
	M	samplecode/SampleApp.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	samplecode/SampleApp.cpp	View		6 chunks	+37 lines, -2 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

LGTM. However, I filed http://code.google.com/p/skia/issues/detail?id=359 in reaction to this. http://codereview.appspot.com/4967061/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): http://codereview.appspot.com/4967061/diff/1/samplecode/SampleApp.cpp#newcode623 samplecode/SampleApp.cpp:623: ...

13 years, 3 months ago (2011-09-08 18:02:45 UTC) #2

Closed with r2244. Try it out and see the bugs!

Expand All Messages | Collapse All Messages