Issue 4965057: Reduce size of filter mask.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4965057: Reduce size of filter mask. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by bungeman

Modified:
13 years, 4 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -50 lines)			Patch
M	src/core/SkDraw.cpp	View	1 2	4 chunks	+8 lines, -14 lines	0 comments	Download
M	src/effects/SkBlurMask.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/effects/SkBlurMask.cpp	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View	1 2	1 chunk	+2 lines, -10 lines	0 comments	Download
M	tests/BlurTest.cpp	View	1 2	1 chunk	+133 lines, -16 lines	0 comments	Download
M	tests/skia_test.cpp	View	1 2	2 chunks	+24 lines, -8 lines	0 comments	Download

Total messages: 4

bungeman

Putting this up early to make sure this makes sense. Currently makes gm, bench, and ...

13 years, 4 months ago (2011-08-31 21:06:25 UTC) #1

bungeman

Margin too big and clipped HQ blur margin too small both fixed. We may want ...

13 years, 4 months ago (2011-09-02 14:06:03 UTC) #2

Committed revision 2211.