cgo: support for mingw 4.5.1 and newer

cgo: support for mingw 4.5.1 and newer

[jp, 2011-08-26 10:05:56]

weakly related files moved from http://codereview.appspot.com/4958042

[vcc, 2011-08-29 04:51:14]

Also need modify cmd/ld/ldpe.c: readsym don't remove underscore and
take care __imp_ in mingw-w64 4.5.1 and newer.

I just remember why I write
if(strncmp(sym->name, "__imp__", 6) == 0)
not
if(strncmp(sym->name, "__imp__", 7) == 0) before. <g>

2011/8/26  <jp@webmaster.ms>:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> weakly related files moved from http://codereview.appspot.com/4958042
>
> Description:
> cgo: support for mingw 4.5.1 and newer
>
> Please review this at http://codereview.appspot.com/4965051/
>
> Affected files:
>  M src/pkg/runtime/cgo/amd64.S
>
>
> Index: src/pkg/runtime/cgo/amd64.S
> ===================================================================
> --- a/src/pkg/runtime/cgo/amd64.S
> +++ b/src/pkg/runtime/cgo/amd64.S
> @@ -4,8 +4,9 @@
>
>  /*
>  * Apple still insists on underscore prefixes for C function names.
> + * mingw-w64 4.5.0 add underscore prefixes for C function names, 4.5.1 and
> up don't add underscore.
>  */
> -#if defined(__APPLE__) || defined(_WIN32)
> +#if defined(__APPLE__) || (defined(_WIN32) && defined(__GNUC__) &&
> (__GNUC__*10000+__GNUC_MINOR__*100+__GNUC_PATCHLEVEL__) < 40501)
>  #define EXT(s) _##s
>  #else
>  #define EXT(s) s
>
>
>

[rsc, 2011-08-29 14:11:12]

> Please review this at http://codereview.appspot.com/4965051/

"You do not have permission to view this issue."

Please run hg change 4965051 and delete
the Private: yes line.

[jp, 2011-08-29 18:33:29]

Wei Guangjing is going to submit CL which will include this patch.

On 2011/08/29 14:11:12, rsc wrote:
> > Please review this at http://codereview.appspot.com/4965051/
> 
> "You do not have permission to view this issue."
> 
> Please run hg change 4965051 and delete
> the Private: yes line.