Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(217)

Issue 4964064: Update cpplint.py to #161: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by erg
Modified:
13 years, 2 months ago
Reviewers:
Mark Mentovai
Base URL:
http://google-styleguide.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Update cpplint.py to #161: - ostream should be treated as a system header - Expand the MockCallback whitelist entry for gMock. - Virtual destructor check shouldn't get confused with "class EXPORT ClassName {" constructs. - Don't warn about the length of "$ Id: ... $" lines. - Better semicolon checks in for() loops. - Better whitespace comment checks. Committed: http://code.google.com/p/google-styleguide/source/detail?r=72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -23 lines) Patch
M cpplint/cpplint.py View 7 chunks +34 lines, -14 lines 0 comments Download
M cpplint/cpplint_unittest.py View 7 chunks +70 lines, -9 lines 0 comments Download

Messages

Total messages: 2
Elliot Glaysher
(There are another 20 revisions to check after this, but I'm so far behind at ...
13 years, 2 months ago (2011-09-06 20:59:55 UTC) #1
Mark Mentovai
13 years, 2 months ago (2011-09-07 00:53:23 UTC) #2
LGTM (rubber-stamp)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b