Optional per-gl-cmd callback in GrGLInterface

[bsalomon, 2011-08-31 15:25:01]

We're seeing yet another crash because of wrong context bug in GL. 

Now that we are able to specify a GrGLInterface per-GrContext we're in position
to have a callback that can be used to set the correct context. I won't check
this in until I've made sure it'll work in Chrome.

http://codereview.appspot.com/4964055/diff/1/gpu/include/GrGLConfig.h
File gpu/include/GrGLConfig.h (right):

http://codereview.appspot.com/4964055/diff/1/gpu/include/GrGLConfig.h#newcode207
gpu/include/GrGLConfig.h:207: (IFACE)->f##X;                                    
     \
We were relying on the fact that this line began the macro implementation in
order to make return values from gl funcs work. e.g.

GrGLenum status = GR_GL_CALL(gl, CheckFramebufferStatus(...));

Now the callback comes first. So I made new versions of the macros for capturing
the return value.

[twiz, 2011-08-31 20:34:15]

LGTM.

Just a few nits and an observation.

http://codereview.appspot.com/4964055/diff/3001/gpu/src/GrGLProgram.cpp
File gpu/src/GrGLProgram.cpp (right):

http://codereview.appspot.com/4964055/diff/3001/gpu/src/GrGLProgram.cpp#newco...
gpu/src/GrGLProgram.cpp:895: GetUniformLocation(progID, VIEW_MATRIX_NAME));
Nit.  Is the formatting here correct?  It looks like you're of by one space.

http://codereview.appspot.com/4964055/diff/3001/gpu/src/GrGLProgram.cpp#newco...
gpu/src/GrGLProgram.cpp:911: GetUniformLocation(progID, EDGES_UNI_NAME));
Nit:  Formatting.

http://codereview.appspot.com/4964055/diff/7001/gpu/include/GrGLInterface.h
File gpu/include/GrGLInterface.h (right):

http://codereview.appspot.com/4964055/diff/7001/gpu/include/GrGLInterface.h#n...
gpu/include/GrGLInterface.h:227: void GrGLDefaultInterfaceCallback(const
GrGLInterface*);
Is there a need to export the default interface callback?  Users of the
GrGLInterface struct may want to compare the callback against the default, but I
can't really think of other uses.

[bsalomon, 2011-08-31 20:49:36]

http://codereview.appspot.com/4964055/diff/3001/gpu/src/GrGLProgram.cpp
File gpu/src/GrGLProgram.cpp (right):

http://codereview.appspot.com/4964055/diff/3001/gpu/src/GrGLProgram.cpp#newco...
gpu/src/GrGLProgram.cpp:895: GetUniformLocation(progID, VIEW_MATRIX_NAME));
On 2011/08/31 20:34:15, twiz wrote:
> Nit.  Is the formatting here correct?  It looks like you're of by one space.

Done.

http://codereview.appspot.com/4964055/diff/3001/gpu/src/GrGLProgram.cpp#newco...
gpu/src/GrGLProgram.cpp:911: GetUniformLocation(progID, EDGES_UNI_NAME));
On 2011/08/31 20:34:15, twiz wrote:
> Nit:  Formatting.

Done.

http://codereview.appspot.com/4964055/diff/7001/gpu/include/GrGLInterface.h
File gpu/include/GrGLInterface.h (right):

http://codereview.appspot.com/4964055/diff/7001/gpu/include/GrGLInterface.h#n...
gpu/include/GrGLInterface.h:227: void GrGLDefaultInterfaceCallback(const
GrGLInterface*);
On 2011/08/31 20:34:15, twiz wrote:
> Is there a need to export the default interface callback?  Users of the
> GrGLInterface struct may want to compare the callback against the default, but
I
> can't really think of other uses.

Good point, made it local to the cpp file.

[bsalomon, 2011-09-01 13:28:44]

Closed with r2207