Issue 4959053: Thread safety: No thread safety analysis option

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4959053: Thread safety: No thread safety analysis option

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by supertri

Modified:
12 years, 7 months ago

Reviewers:
chandlerc

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	lib/Sema/AnalysisBasedWarnings.cpp	View		1 chunk	+4 lines, -0 lines	2 comments	Download
	M	test/SemaCXX/warn-thread-safety-analysis.cpp	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

chandlerc

http://codereview.appspot.com/4959053/diff/1/lib/Sema/AnalysisBasedWarnings.cpp File lib/Sema/AnalysisBasedWarnings.cpp (right): http://codereview.appspot.com/4959053/diff/1/lib/Sema/AnalysisBasedWarnings.cpp#newcode1333 lib/Sema/AnalysisBasedWarnings.cpp:1333: // FIXME: follow the decl chain for enclosing contexts ...

12 years, 7 months ago (2011-09-02 06:45:58 UTC) #1

supertri

12 years, 7 months ago (2011-09-02 22:25:09 UTC) #2

http://codereview.appspot.com/4959053/diff/1/lib/Sema/AnalysisBasedWarnings.cpp
File lib/Sema/AnalysisBasedWarnings.cpp (right):

http://codereview.appspot.com/4959053/diff/1/lib/Sema/AnalysisBasedWarnings.c...
lib/Sema/AnalysisBasedWarnings.cpp:1333: // FIXME: follow the decl chain for
enclosing contexts to identify any
On 2011/09/02 06:45:58, chandlerc wrote:
> What decl chain? We don't support nested functions.
> 
> Are you imagining constructs such as this?
> 
> void f() __attribute__((no_thread_safety_analysis));
> void f() {
>   struct S {
>     void m() {
>       // do something unsafe
>     }
>   };
>   // ...
> }
> 
> If so, I would gladly not support that. Force the programmer to annotate each
> function explicitly.
> 

Ok, sounds good. FIXME removed.

Expand All Messages | Collapse All Messages